allow appRoutes to start with the same string as the basePath

[pgayvallet]

Summary

Fix #66228

Because of the BasePath implementation of remove, allowing apps to have an url part matching exactly the basePath could have unexpected behavior, as we are using BasePath.prepend and BasePath.remove to manipulate them internally:

const basePath = new BasePath(`/base-path`);
const appRoute = '/base-path/app';

// dangerous:
basePath.preprend(appRoute); // `/base-path/base-path/app`
basePath.remove(appRoute); // `/app`

However this only occurs when the basePath contained in the appRoute is suffixed with a /. Other cases are actually fine:

const basePath = new BasePath(`/base-path`);
const appRoute = '/base-path-not/app';

basePath.preprend(appRoute); // `/base-path/base-path-not/app`
basePath.remove(appRoute); // `/base-path-not/app`

PR fixes the basePath check when registered apps.

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

[elasticmachine]

Pinging @elastic/kibana-platform (Team:Platform)

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 4f27e66

History

• 💚 Build #49165 succeeded 2167473

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream