KibanaContext in index pattern managment ui #66985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladLasitsa
added
Feature:Data Views
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
VladLasitsa
force-pushed
the
kibana_context_in_index_pattern_managment_ui
branch
from
726d5e3
to
280aa24
Compare
mattkime
reviewed
May 20, 2020
.../components/create_index_pattern_wizard/components/step_index_pattern/step_index_pattern.tsx
Outdated
Show resolved
Hide resolved
mattkime
reviewed
May 20, 2020
src/plugins/index_pattern_management/public/components/edit_index_pattern/tabs/tabs.tsx
Outdated
Show resolved
Hide resolved
mattkime
reviewed
May 20, 2020
.../components/create_index_pattern_wizard/components/step_index_pattern/step_index_pattern.tsx
Show resolved
Hide resolved
mattkime
reviewed
May 20, 2020
streamich
approved these changes
May 20, 2020
.../components/create_index_pattern_wizard/components/step_index_pattern/step_index_pattern.tsx
Outdated
Show resolved
Hide resolved
| @@ -66,6 +60,10 @@ interface StepIndexPatternState { | |||
| } | |||
|
|
|||
| export class StepIndexPattern extends Component<StepIndexPatternProps, StepIndexPatternState> { | |||
| static contextType = contextType; | |||
|
|
|||
| declare readonly context: IndexPatternManagmentContextValue; | |||
There was a problem hiding this comment.
Nit, maybe it is more future-proof to use withKibana higher order component instead of this legacy context API.
export const StepIndexPattern = withKibana(StepIndexPatternPure);There was a problem hiding this comment.
Or useKibana hook
export const StepIndexPattern = props => {
const {services} = useKibana();
return <StepIndexPatternPure {...props} services={services} />;
};There was a problem hiding this comment.
I think it's just a different way to pass the context. I found out that we use both ways in the application. Regarding use Kibana hook, I used it for functional components.
|
overall the changes look good but this could use another pass to use |
…_index_pattern_managment_ui
|
@elasticmachine merge upstream |
…_index_pattern_managment_ui
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
VladLasitsa
added a commit
to VladLasitsa/kibana
that referenced
this pull request
May 25, 2020
* Using KibanaContext instead of passing dependencies. * Fixed comments * Delete index.scss * Added comment for workaround * Fixed tests * Fixed eslint Co-authored-by: Alexey Antonov <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
VladLasitsa
added a commit
that referenced
this pull request
May 25, 2020
* Using KibanaContext instead of passing dependencies. * Fixed comments * Delete index.scss * Added comment for workaround * Fixed tests * Fixed eslint Co-authored-by: Alexey Antonov <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Alexey Antonov <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
jloleysens
added a commit
that referenced
this pull request
May 26, 2020
…ine-editor * 'master' of github.com:elastic/kibana: (129 commits) [Canvas] Force embeddables to refresh when renderable reevaluated (#67133) [Canvas] Better handling navigating to/from canvas (#66407) [Ingest pipelines] Fix schema validation for simulate and update routes (#67199) do not use es from setup (#67277) Auto expand replicas for event log (#67286) Observability & APM do not use elasticsearch client provided via setup contract (#67263) Fix privileges check when security is not enabled (#67308) add IIS home (#66918) [ML] Adding additional job service endpoint tests (#66892) [Ingest Manager] Update fleet internal doc with latest flags (#67193) [Discover] Deangularize the loading spinner (#67165) Add `application.navigateToUrl` core API (#67110) Improve indexpattern without timefield functional test (#67031) KibanaContext in index pattern managment ui (#66985) Fix Azure metrics tutorial inside the App Home/ Add data area (#66901) add azure logs home (#66910) fix: rum agent should work correctly on new platform (#67037) [test_utils/Testbed] Move to src/test_utils folder (OSS) (#66898) only block registration when appRoute contains the exact basePath (#67125) Changed actions API endpoints urls to follow Kibana STYLEGUIDE (#65936) ... # Conflicts: # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form_fields.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simplified component dependencies with KibanaContext