Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quiet option #541

Merged
merged 3 commits into from
Dec 9, 2016
Merged

Add quiet option #541

merged 3 commits into from
Dec 9, 2016

Conversation

malept
Copy link
Member

@malept malept commented Dec 9, 2016

Have you read the section in CONTRIBUTING.md about pull requests?

Yes

Summarize your changes:

When set, this prevents printing Electron Packager specific warnings and informational messages to the console. This does not disable errors.

CC: @MarshallOfSound mostly because we can get rid of that console monkeypatch workaround in Electron Forge.

Fixes #538.

Are your changes appropriately documented?

Yes (CLI usage, API docs).

Do your changes have sufficient test coverage?

Yes.

Does the testsuite pass successfully on your local machine?

Yes.

When set, this prevents printing Electron Packager specific warnings and
informational messages to the console. This does *not* disable errors.

Fixes #538.
@MarshallOfSound
Copy link
Member

Haha, that monkeypatch makes me cry every time I look at it 😆

@malept malept merged commit e3ec883 into master Dec 9, 2016
@malept malept deleted the quiet-option branch December 9, 2016 04:42
function subOptionWarning (properties, optionName, parameter, value) {
function info (message, quiet) {
if (!quiet) {
console.error(message)
Copy link

@MatthewTeolis MatthewTeolis Aug 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malept Is there a reason you chose console.error instead of console.info/console.log?

When running in Maven and Jenkins, console.error creates a misleading error message (also displayed in red):

[ERROR] Packaging app for platform win32 x64 using electron v1.6.10

This makes it look like the packager failed to package the app

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't. Explanation is here: #228 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants