Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps in garden : ign-gui7 #313

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Bumps in garden : ign-gui7 #313

merged 1 commit into from
Nov 18, 2021

Conversation

scpeters
Copy link
Member

Signed-off-by: Steve Peters <[email protected]>
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't done bumps before, does there need to be a ign-rendering7 prerelease before this is ready?

@scpeters
Copy link
Member Author

I haven't done bumps before, does there need to be a ign-rendering7 prerelease before this is ready?

I ran a script that created all the pull requests at once. I'm going to update that script to do things in a better order

@chapulina
Copy link
Contributor

does there need to be a ign-rendering7 prerelease before this is ready?

Nope, we just need to enable CI to use nightlies

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@scpeters
Copy link
Member Author

I retriggered the homebrew build now that osrf/homebrew-simulation#1686 is merged

@scpeters
Copy link
Member Author

I retriggered the homebrew build now that osrf/homebrew-simulation#1686 is merged

💚

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #313 (11037c5) into main (53360bb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #313   +/-   ##
=======================================
  Coverage   65.47%   65.47%           
=======================================
  Files          32       32           
  Lines        4686     4686           
=======================================
  Hits         3068     3068           
  Misses       1618     1618           
Impacted Files Coverage Δ
src/plugins/minimal_scene/MinimalScene.cc 58.92% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c46a59d...11037c5. Read the comment docs.

@scpeters
Copy link
Member Author

some test failures in focal github action, but otherwise 🍏, so I'll merge

@scpeters scpeters merged commit 29d558c into main Nov 18, 2021
@scpeters scpeters deleted the bump_garden_ign-gui7 branch November 18, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants