Merge 6 -> main #209
Merged
Merge 6 -> main #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
* Suppress windows warnings Signed-off-by: Steve Peters <[email protected]>
The ign-math Pose addition operator is going to be deprecated, so use the multiplication operator instead. It works in the opposite order, matching the behavior of coordinate transform multiplication. Signed-off-by: Steve Peters <[email protected]>
* Parse localization tag taking into account world frame orientation and heading offset. Signed-off-by: Aditya <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Added SetActive and IsActive function for enabling and disabling a sensor. The sensor is active by default. A disabled / non-active sensor will not generate or publish data when the Update function is called. It will however update if the force argument is true, similar to the behavior in gazebo-classic. Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 70.87% 71.13% +0.25%
==========================================
Files 30 30
Lines 3114 3173 +59
==========================================
+ Hits 2207 2257 +50
- Misses 907 916 +9
Continue to review full report at Codecov.
|
chapulina
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
It doesn't seem to be caused by this PR, but I noticed that ign-rendering is having a hard time finding ign-plugin on Focal and Jammy:
CMake Warning at /usr/lib/x86_64-linux-gnu/cmake/ignition-rendering7/ignition-rendering7-config.cmake:94 (find_package):
By not providing "Findignition-plugin1.cmake" in CMAKE_MODULE_PATH this
project has asked CMake to find a package configuration file provided by
"ignition-plugin1", but CMake did not find one.
Could not find a package configuration file provided by "ignition-plugin1"
with any of the following names:
ignition-plugin1Config.cmake
ignition-plugin1-config.cmake
Add the installation prefix of "ignition-plugin1" to CMAKE_PREFIX_PATH or
set "ignition-plugin1_DIR" to a directory containing one of the above
files. If "ignition-plugin1" provides a separate development package or
SDK, be sure it has been installed.
Call Stack (most recent call first):
/usr/share/cmake/ignition-cmake2/cmake2/IgnUtils.cmake:189 (find_package)
CMakeLists.txt:69 (ign_find_package)
yeah, I think this is a problem with the debian metadata: gazebo-release/gz-rendering6-release#9 cc @j-rivero |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port ign-msgs6 to main
Branch comparison: main...ign-sensors6
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)