Fixed typo in gz sim python api #2578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjo129
previously requested changes
Sep 2, 2024
There was a problem hiding this comment.
I'm a bit torn by this change. On one hand given that we have released this, wouldn't this change break the API? Shouldn't we do a deprecation first?
On the other given how long its taken for this bug to be reported, maybe its fine to just go ahead and change the name.
| @@ -94,7 +94,7 @@ void defineSimJoint(py::object module) | |||
| py::arg("ecm"), | |||
| py::arg("limits"), | |||
| "Set the effort limits on a joint axis.") | |||
| .def("set_position_imits", &gz::sim::Joint::SetPositionLimits, | |||
| .def("set_position_limits", &gz::sim::Joint::SetPositionLimits, | |||
There was a problem hiding this comment.
Shouldn't we be deprecating this instead of removing it.
There was a problem hiding this comment.
@azeey opinions here?
There was a problem hiding this comment.
Yeah, I think we should deprecate the old function and add the new one.
There was a problem hiding this comment.
@azeey this is wrong in older versions, what should we do?
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
ahcorde
force-pushed
the
ahcorde/sim8/fix_python_typo
branch
from
83b80c8
to
27a46da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #
Summary
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.