Release candidate 0.3.0 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change default name of output_var - mention this default name in the documentation
New function cluster_locs(): detect well clusters
If TRUE, the result includes wells with missing filterdepth. Defaults to FALSE
Reexport inborutils::convertdf_enc() (fixes #35)
This is because in some cases records for the same observation well exist with different statuscodes.
Accomplished by filtering for specific value of fields 'PeilpuntOpenbaarheidTypeCode' and 'PeilpuntOpenbaarheidCode'
This will prevent the installation of an older R version over released R (like here: https://travis-ci.com/github/inbo/watina/builds/163763120#L1188), which resulted in a build error further down.
Co-authored-by: Floris Vanderhaeghe <[email protected]>
restore the original filter change the control of duplicated rows
This is a workaround addressing issue #55. The issue is further investigated in tidyverse/dbplyr#438.
get_xg3(), get_chem(): a fix for copy_to issue
Previously, two collects were done when masking, now only one.
get_locs(): speed up masking
as_points(), get_locs(): warn for duplicated coordinate pairs
get_chem(): return column 'unit', not 'units'
Import inbodb::connect_inbo_dbase() and put inborutils::convertdf_enc() back in watina
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparations for version
0.3.0.Currently ready (we think):
cluster_locs()to spatially cluster locations (well clusters) (New function cluster_locs(): detect well clusters #39)get_locs():filterdepth(argumentfilterdepth_na)filterdepthvalues in a conservative way, based ontubelength(argumentfilterdepth_guess, Extending get_locs() #44)filterdepth(Extending get_locs() #44)obswell_aggr, Extending get_locs() #44)convertdf_enc()is now reexported frominborutilsAlso, a number of smaller fixes and enhancements were made.
Further plan before merging: applying in real-life cases. All code contributions remain welcome (make your PR relative to
rc0.3).