Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Rip out half-implemented m.login.saml2 support #4265

Merged
merged 4 commits into from
Dec 6, 2018
Merged

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Dec 5, 2018

This was implemented in an odd way that left most of the work to the client, in a way that I really didn't understand. It's going to be a pain to maintain, so let's start by ripping it out.

This was implemented in an odd way that left most of the work to the client, in
a way that I really didn't understand. It's going to be a pain to maintain, so
let's start by ripping it out.
@richvdh richvdh requested a review from a team December 5, 2018 16:40
It turns out we were relying on dateutil being pulled in transitively by
pysaml2. There's no need for that bloat.
@richvdh
Copy link
Member Author

richvdh commented Dec 5, 2018

(now includes #4266 to make the CI work)

@hawkowl
Copy link
Contributor

hawkowl commented Dec 5, 2018

@richvdh could you merge this forward please?

@codecov-io
Copy link

Codecov Report

Merging #4265 into develop will increase coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4265      +/-   ##
===========================================
+ Coverage    73.54%   73.62%   +0.08%     
===========================================
  Files          299      298       -1     
  Lines        29849    29776      -73     
  Branches      4884     4875       -9     
===========================================
- Hits         21953    21924      -29     
+ Misses        6459     6418      -41     
+ Partials      1437     1434       -3
Impacted Files Coverage Δ
synapse/python_dependencies.py 40.9% <ø> (ø) ⬆️
synapse/config/homeserver.py 90.32% <ø> (-0.31%) ⬇️
synapse/handlers/register.py 74.41% <ø> (+3.67%) ⬆️
synapse/rest/client/v1/login.py 63.87% <0%> (+5.05%) ⬆️
synapse/state/v1.py 90.69% <0%> (-1.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8d9846...c6d1858. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Dec 5, 2018

Codecov Report

Merging #4265 into develop will increase coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4265      +/-   ##
===========================================
+ Coverage    73.54%   73.63%   +0.08%     
===========================================
  Files          299      298       -1     
  Lines        29849    29776      -73     
  Branches      4884     4875       -9     
===========================================
- Hits         21953    21925      -28     
+ Misses        6459     6417      -42     
+ Partials      1437     1434       -3
Impacted Files Coverage Δ
synapse/python_dependencies.py 40.9% <ø> (ø) ⬆️
synapse/config/homeserver.py 90.32% <ø> (-0.31%) ⬇️
synapse/handlers/register.py 74.41% <ø> (+3.67%) ⬆️
synapse/rest/client/v1/login.py 63.87% <0%> (+5.05%) ⬆️
synapse/util/file_consumer.py 80.7% <0%> (-1.76%) ⬇️
synapse/state/v1.py 90.69% <0%> (-1.56%) ⬇️
synapse/state/v2.py 93.29% <0%> (-0.52%) ⬇️
synapse/handlers/user_directory.py 71.03% <0%> (+0.3%) ⬆️
synapse/handlers/device.py 81.45% <0%> (+0.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a3e24a...8e25215. Read the comment docs.

@hawkowl hawkowl merged commit b0c24a6 into develop Dec 6, 2018
@hawkowl hawkowl deleted the rav/remove_old_saml2 branch December 6, 2018 08:44
richvdh added a commit that referenced this pull request Jan 8, 2019
Synapse 0.34.1rc1 (2019-01-08)
==============================

Features
--------

- Special-case a support user for use in verifying behaviour of a given server. The support user does not appear in user directory or monthly active user counts. ([\#4141](#4141), [\#4344](#4344))
- Support for serving .well-known files ([\#4262](#4262))
- Rework SAML2 authentication ([\#4265](#4265), [\#4267](#4267))
- SAML2 authentication: Initialise user display name from SAML2 data ([\#4272](#4272))
- Synapse can now have its conditional/extra dependencies installed by pip. This functionality can be used by using `pip install matrix-synapse[feature]`, where feature is a comma separated list with the possible values `email.enable_notifs`, `matrix-synapse-ldap3`, `postgres`, `resources.consent`, `saml2`, `url_preview`, and `test`. If you want to install all optional dependencies, you can use "all" instead. ([\#4298](#4298), [\#4325](#4325), [\#4327](#4327))
- Add routes for reading account data. ([\#4303](#4303))
- Add opt-in support for v2 rooms ([\#4307](#4307))
- Add a script to generate a clean config file ([\#4315](#4315))
- Return server data in /login response ([\#4319](#4319))

Bugfixes
--------

- Fix contains_url check to be consistent with other instances in code-base and check that value is an instance of string. ([\#3405](#3405))
- Fix CAS login when username is not valid in an MXID ([\#4264](#4264))
- Send CORS headers for /media/config ([\#4279](#4279))
- Add 'sandbox' to CSP for media reprository ([\#4284](#4284))
- Make the new landing page prettier. ([\#4294](#4294))
- Fix deleting E2E room keys when using old SQLite versions. ([\#4295](#4295))
- The metric synapse_admin_mau:current previously did not update when config.mau_stats_only was set to True ([\#4305](#4305))
- Fixed per-room account data filters ([\#4309](#4309))
- Fix indentation in default config ([\#4313](#4313))
- Fix synapse:latest docker upload ([\#4316](#4316))
- Fix test_metric.py compatibility with prometheus_client 0.5. Contributed by Maarten de Vries <[email protected]>. ([\#4317](#4317))
- Avoid packaging _trial_temp directory in -py3 debian packages ([\#4326](#4326))
- Check jinja version for consent resource ([\#4327](#4327))
- fix NPE in /messages by checking if all events were filtered out ([\#4330](#4330))
- Fix `python -m synapse.config` on Python 3. ([\#4356](#4356))

Deprecations and Removals
-------------------------

- Remove the deprecated v1/register API on Python 2. It was never ported to Python 3. ([\#4334](#4334))

Internal Changes
----------------

- Getting URL previews of IP addresses no longer fails on Python 3. ([\#4215](#4215))
- drop undocumented dependency on dateutil ([\#4266](#4266))
- Update the example systemd config to use a virtualenv ([\#4273](#4273))
- Update link to kernel DCO guide ([\#4274](#4274))
- Make isort tox check print diff when it fails ([\#4283](#4283))
- Log room_id in Unknown room errors ([\#4297](#4297))
- Documentation improvements for coturn setup. Contributed by Krithin Sitaram. ([\#4333](#4333))
- Update pull request template to use absolute links ([\#4341](#4341))
- Update README to not lie about required restart when updating TLS certificates ([\#4343](#4343))
- Update debian packaging for compatibility with transitional package ([\#4349](#4349))
- Fix command hint to generate a config file when trying to start without a config file ([\#4353](#4353))
- Add better logging for unexpected errors while sending transactions ([\#4358](#4358))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants