Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add GET account data routes #4303

Merged
merged 4 commits into from
Jan 7, 2019
Merged

Add GET account data routes #4303

merged 4 commits into from
Jan 7, 2019

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Dec 18, 2018

Sytest: matrix-org/sytest#536
Proposal: matrix-org/matrix-spec-proposals#1339

This was done with a community hat on:
Signed-off-by: Travis Ralston [email protected]

turt2live added a commit to matrix-org/sytest that referenced this pull request Dec 18, 2018
@turt2live turt2live requested a review from a team December 18, 2018 03:09
@codecov-io
Copy link

Codecov Report

Merging #4303 into develop will decrease coverage by 0.01%.
The diff coverage is 52.94%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4303      +/-   ##
===========================================
- Coverage    73.51%   73.49%   -0.02%     
===========================================
  Files          302      302              
  Lines        29919    29935      +16     
  Branches      4900     4904       +4     
===========================================
+ Hits         21995    22002       +7     
- Misses        6483     6489       +6     
- Partials      1441     1444       +3
Impacted Files Coverage Δ
synapse/rest/client/v2_alpha/account_data.py 75.43% <52.94%> (-9.93%) ⬇️
synapse/handlers/user_directory.py 71.08% <0%> (-0.31%) ⬇️
synapse/handlers/search.py 80.24% <0%> (ø) ⬆️
synapse/handlers/federation.py 61.72% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2f7c4e...b4f84a6. Read the comment docs.

Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to wait until the MSC is merged?

)

if event is None:
raise SynapseError(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a specific NotFoundError that may be more applicable

@turt2live
Copy link
Member Author

I'd argue the MSC has already gone though a FCP and is pending implementation, but the bot thinks otherwise.

@erikjohnston
Copy link
Member

If its passed FCP, then we should fix it up and just merge it, otherwise its just confusing.

@turt2live
Copy link
Member Author

right, so it seems like instead of fighting the bot the thing should just go through the bot's process.

@richvdh richvdh requested a review from a team January 3, 2019 17:41
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@richvdh richvdh merged commit bc1fa8c into develop Jan 7, 2019
richvdh pushed a commit to matrix-org/sytest that referenced this pull request Jan 7, 2019
@turt2live turt2live deleted the travis/get-account-data branch January 7, 2019 14:40
richvdh added a commit that referenced this pull request Jan 8, 2019
Synapse 0.34.1rc1 (2019-01-08)
==============================

Features
--------

- Special-case a support user for use in verifying behaviour of a given server. The support user does not appear in user directory or monthly active user counts. ([\#4141](#4141), [\#4344](#4344))
- Support for serving .well-known files ([\#4262](#4262))
- Rework SAML2 authentication ([\#4265](#4265), [\#4267](#4267))
- SAML2 authentication: Initialise user display name from SAML2 data ([\#4272](#4272))
- Synapse can now have its conditional/extra dependencies installed by pip. This functionality can be used by using `pip install matrix-synapse[feature]`, where feature is a comma separated list with the possible values `email.enable_notifs`, `matrix-synapse-ldap3`, `postgres`, `resources.consent`, `saml2`, `url_preview`, and `test`. If you want to install all optional dependencies, you can use "all" instead. ([\#4298](#4298), [\#4325](#4325), [\#4327](#4327))
- Add routes for reading account data. ([\#4303](#4303))
- Add opt-in support for v2 rooms ([\#4307](#4307))
- Add a script to generate a clean config file ([\#4315](#4315))
- Return server data in /login response ([\#4319](#4319))

Bugfixes
--------

- Fix contains_url check to be consistent with other instances in code-base and check that value is an instance of string. ([\#3405](#3405))
- Fix CAS login when username is not valid in an MXID ([\#4264](#4264))
- Send CORS headers for /media/config ([\#4279](#4279))
- Add 'sandbox' to CSP for media reprository ([\#4284](#4284))
- Make the new landing page prettier. ([\#4294](#4294))
- Fix deleting E2E room keys when using old SQLite versions. ([\#4295](#4295))
- The metric synapse_admin_mau:current previously did not update when config.mau_stats_only was set to True ([\#4305](#4305))
- Fixed per-room account data filters ([\#4309](#4309))
- Fix indentation in default config ([\#4313](#4313))
- Fix synapse:latest docker upload ([\#4316](#4316))
- Fix test_metric.py compatibility with prometheus_client 0.5. Contributed by Maarten de Vries <[email protected]>. ([\#4317](#4317))
- Avoid packaging _trial_temp directory in -py3 debian packages ([\#4326](#4326))
- Check jinja version for consent resource ([\#4327](#4327))
- fix NPE in /messages by checking if all events were filtered out ([\#4330](#4330))
- Fix `python -m synapse.config` on Python 3. ([\#4356](#4356))

Deprecations and Removals
-------------------------

- Remove the deprecated v1/register API on Python 2. It was never ported to Python 3. ([\#4334](#4334))

Internal Changes
----------------

- Getting URL previews of IP addresses no longer fails on Python 3. ([\#4215](#4215))
- drop undocumented dependency on dateutil ([\#4266](#4266))
- Update the example systemd config to use a virtualenv ([\#4273](#4273))
- Update link to kernel DCO guide ([\#4274](#4274))
- Make isort tox check print diff when it fails ([\#4283](#4283))
- Log room_id in Unknown room errors ([\#4297](#4297))
- Documentation improvements for coturn setup. Contributed by Krithin Sitaram. ([\#4333](#4333))
- Update pull request template to use absolute links ([\#4341](#4341))
- Update README to not lie about required restart when updating TLS certificates ([\#4343](#4343))
- Update debian packaging for compatibility with transitional package ([\#4349](#4349))
- Fix command hint to generate a config file when trying to start without a config file ([\#4353](#4353))
- Add better logging for unexpected errors while sending transactions ([\#4358](#4358))
spantaleev added a commit to devture/matrix-corporal that referenced this pull request Jan 25, 2019
Now that matrix-org/synapse#4303 is implemented,
we don't need to resort to doing `/sync` to
retrieve account data.

We can do it via the new GET endpoint of the API:
`/user/{user_id}/account_data/{account_dataType}`

This API endpoint landed in Synapse v0.34.1,
so versions prior to that will not be supported anymore.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants