Release/v2.3.8 #960
Merged
Release/v2.3.8 #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k/#12148-Chat-message-emoji-reactions
Also added the startUpload command
…causing a linker error.
The `keyid` has been recently changed from `uint64_t` to `uint32_t`. It does not cause any issue on 64bits binaries, but on certain libc stacks on Android phones, it may crash at `strlen()`
…or_windows_without_webrtc CHT-415. Update for building megaclc on windows without webrtc
CHT-414. Adjust datatype for log message
CHT-417. Fix wrong update of unread messages (HOTFIX for develop)
The idea is post this log message outside of method findLastTextMsg, to avoid post it upon every reconnection, and other situations that will happen frequently, and where the message doesn't give new information.
#CHT-151. Handle ECONN_REFUSED upon connection to chatd / presenced
#CHT-284. Avoid a log line with notification state same than previous
The break refers to the loop `for`, not to the switch
CHT-423. Fix wrong error management
Co-authored-by: Lancy <[email protected]>
Use “get” only for methods that return objects and values indirectly.
…actions iOS bindings for chat reactions
Apply hotfixes from master
To preserve the order of reactions, we need to order query results by rowId, when we are retrieving them from cache. Replace multimap by a vector of pairs to preserve the order.
- use stl containers that preserve the order of inserted elements - improve algorithm
- A message can't exceed maxMessageReactions - Our own user can't react more than maxOwnReactions
CHT-429. Reactions are added in wrong order
CHT-428. Add limitations to Reactions
Upon encrypt/decrypt a reaction of a message, the key to encrypt the reaction depends on the key used to encrypt the message. Hence, when reacting to a message posted in EKR off, but the chat is EKR on, the key should be the unified key, not the specific key of the message (which does not exist).
…ith-EKR-on CHT-433. Select right key for reaction in private mode
In this way, the local av change is notified in the right moment
CHT-430: Fire onChatCallUpdate at setCall when we set local av flags
…ions CHT-428. Comment reactions limitations code
Our own user must be added to users reaction list, in the order in which reactions were received from chatd.
CHT-445. The order reaction participants who reacted for an emoji is wrong
Android bindings for chat reactions
sergiohs84
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement
[CHT-415] - update for building megaclc on windows without webrtc
Bug
[CHT-284] - Avoid a log line with notification state same than previous
[CHT-406] - Issue with multiple last Text message
[CHT-416] - cmake is missing Qt settings
[CHT-433] - Crash adding reaction to msg of public history
[CHT-445] - The order reaction participants who reacted for an emoji is wrong
Target apps/s