-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libwebp] update to v1.0.2 #5210
Conversation
… custom find_package script in favour of original Config files for cmake
e6d4aff
to
783cce5
Compare
I also expanded the port a little bit, enable building of all exe tools. |
And now I added a compatibility layer inside the official cmake config file, in order to expose the symbol checked by some projects. |
This PR causes regressions for I pulled this PR and #5228 to a local branch for testing. The log shows a lot of unresolved external symbol errors:
|
@vicroms All my PRs opened at the moment are extremely intertwined. I disentagled all of them in different PRs because of some previous experience here, when I did a "huge" PR for OpenCV3 but Robert preferred to close my PR, push changes individually and loose track of my work #2764. In view of it I tried my best to separate them but unfortunately I think that without the PR #5227 I fear you cannot solve those problems. Could you please check with also that PR in your local branch? |
I haven't had the time to keep working on it. The last thing I did was merge #5227, #5228, #5210, and #5265 into the same branch, but the issue persisted. Does I pushed my branch to https:/Microsoft/vcpkg/tree/dev/viromer/cenit-prs |
x64-windows is my default triplet, so I am confident especially on that triplet... I will test everything again |
closed in favor of #5417 |
Besides the upgrade, I also did some deep maintenance to the port, which will requires some extensive testing I had no time to do: