Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenEXR] Update to v2.3.0 #5227

Closed
wants to merge 5 commits into from
Closed

Conversation

cenit
Copy link
Contributor

@cenit cenit commented Jan 24, 2019

Upgrade the whole package:

  • move to github
  • update to v2.3.0
  • improve the FindOpenEXR.cmake, maintaining backwards compatibility (there's an official one distributed with the package but it is completely different, for now it is avoided)
  • remove the ilmbase port because now it is part of OpenEXR
  • enable installation of OpenEXR tools

…still maintaining backwards compatibility (there's an official one distributed with the package but it is completely different, for now it is avoided)
@UnaNancyOwen
Copy link
Contributor

[x] remove the ilmbase port because now it is part of OpenEXR

I agree. I think it is a good proposal than my pull request #4820. 👍
@ras0219-msft What do you think?

@cenit
Copy link
Contributor Author

cenit commented Jan 24, 2019

I just updated freeimage to comply with the new OpenEXR.
I noticed that also updates to alembic and to OpenVDB may be necessary, due to this upgrade...

edit: no update is necessary to alembic

@cenit
Copy link
Contributor Author

cenit commented Jan 30, 2019

this PR is necessary to build #5169 with all features

This was referenced Jan 30, 2019
@vicroms vicroms self-assigned this Feb 12, 2019
@vicroms
Copy link
Member

vicroms commented Feb 21, 2019

@cenit
Shouldn't OpenEXR be disabled for UWP? The now removed port for ilmbase didn't support UWP, and now that it is embedded into OpenEXR doesn't the same restriction apply?

@cenit
Copy link
Contributor Author

cenit commented Feb 21, 2019

you're right, there's a failure in ilmbase due to getenv and strerror function usage.
Sorry I didn't check all the ports with all the triplets, CI would be great to be exposed ;)
I am going to fix it asap

@vicroms
Copy link
Member

vicroms commented Feb 21, 2019

Great. I made a few changes so that OpenEXR can be built on Linux and MacOS, for now those changes are only on my branch.

I also pulled your changes to openvdb (PR #5265) as the removal of ilmbase would cause regressions otherwise, the CI build takes a while to finish, but hopefully this time it is successful.

@cenit
Copy link
Contributor Author

cenit commented Feb 26, 2019

closed in favor of #5417

@cenit cenit closed this Feb 26, 2019
@cenit cenit deleted the dev/cenit/openexr branch March 7, 2019 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants