Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed many remaining compiler warnings #1677

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Fixed many remaining compiler warnings #1677

merged 1 commit into from
Oct 13, 2022

Conversation

marcalff
Copy link
Member

Fixes #249

Changes

Fixed trivial warnings reported by:

  • gcc
  • clang
  • msvc

Elasticsearch:

  • fixed incomplete error handling in switch case
  • reworded error logs

protobuf:

  • silenced warnings for clang in protobuf_include_prefix.h

thrift:

  • silenced warnings for gcc in thrift_include_prefix.h / thrift_include_suffix.h
  • silenced warnings for gcc in CMakeList.txt, for thrift-gen generated code.

gtest:

  • silenced warnings for gcc in unit tests using GTest TYPED_TEST()

metrics:

  • removed dead code, GetInstrumentClass()
  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff
Fixes open-telemetry#249
7e56cd9 
Fixed many remaining compiler warnings.
@marcalff marcalff requested a review from a team October 12, 2022 21:02
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #1677 (7e56cd9) into main (99f2ba4) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1677      +/-   ##
==========================================
+ Coverage   85.76%   85.82%   +0.07%     
==========================================
  Files         170      169       -1     
  Lines        5137     5133       -4     
==========================================
  Hits         4405     4405              
+ Misses        732      728       -4
Impacted Files Coverage Δ
...try/nostd/internal/absl/types/bad_variant_access.h 100.00% <ø> (ø)
...k/metrics/exemplar/fixed_size_exemplar_reservoir.h 71.43% <100.00%> (ø)
...dk/metrics/exemplar/histogram_exemplar_reservoir.h 80.00% <100.00%> (ø)
...ry/sdk/metrics/exemplar/with_trace_sample_filter.h 100.00% <100.00%> (ø)

lalitb
lalitb approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done. Thanks for the effort :)

@esigo esigo merged commit f29703b into open-telemetry:main Oct 13, 2022
ays7 added a commit to ays7/opentelemetry-cpp that referenced this pull request Oct 29, 2022
@ays7
Merge commit '9acde87b08b225ce511fa8a20c6cba14f2921518' into ays/thre…
456a0e7 
…ad-local-stack

* commit '9acde87b08b225ce511fa8a20c6cba14f2921518': (36 commits)
  Prepare v1.7.0 release with Metrics API/SDK GA. (open-telemetry#1721)
  Fix: 1712 -  Validate Instrument meta data (name, unit, description) (open-telemetry#1713)
  Document libthrift 0.12.0 doesn't work with Jaeger exporter (open-telemetry#1714)
  Fix:1674, Add Monotonic Property to Sum Aggregation, and unit tests for Up Down Counter (open-telemetry#1675)
  [Metrics SDK] Move Metrics Exemplar processing behind feature flag (open-telemetry#1710)
  [Metrics API/SDK] Change Meter API/SDK to return nostd::unique_ptr for Sync Instruments (open-telemetry#1707)
  [Metrics] Switch to explicit 64 bit integers (open-telemetry#1686)
  Add metrics e2e test to asan & tsan CI (open-telemetry#1670)
  Add otlp-grpc example bazel (open-telemetry#1708)
  [Metrics SDK] Add support for Pull Metric Reader (open-telemetry#1701)
  Fix debug log of OTLP HTTP exporter and ES log exporter (open-telemetry#1703)
  [SEMANTIC CONVENTIONS] Upgrade to version 1.14.0 (open-telemetry#1697)
  Fix a potential precision loss on integer in ReservoirCellIndexFor (open-telemetry#1696)
  fix Histogram crash (open-telemetry#1685)
  Fix:1676 Segfault when short export period is used for metrics  (open-telemetry#1682)
  Add timeout support to MeterContext::ForceFlush (open-telemetry#1673)
  Add CMake OTELCPP_MAINTAINER_MODE (open-telemetry#1650)
  [DOCS] - Minor updates to OStream Metrics exporter documentation (open-telemetry#1679)
  Fix:open-telemetry#1575 API Documentation for Metrics SDK and API (open-telemetry#1678)
  Fixes open-telemetry#249 (open-telemetry#1677)
  ...
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
@marcalff @yxue
Fixes open-telemetry#249 (open-telemetry#1677)
0b5b781 
Fixed many remaining compiler warnings.
@marcalff marcalff deleted the fix_compiler_warnings_249 branch July 4, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

@esigo esigo esigo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler warnings clean-up
3 participants
@marcalff @lalitb @esigo