fix Histogram crash #1685
Merged
fix Histogram crash #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1685 +/- ##
==========================================
- Coverage 86.36% 86.31% -0.04%
==========================================
Files 169 169
Lines 5152 5156 +4
==========================================
+ Hits 4449 4450 +1
- Misses 703 706 +3
|
lalitb
reviewed
Oct 14, 2022
| { | ||
| if (aggregation_config && aggregation_config->boundaries_.size()) | ||
| auto ac = std::dynamic_pointer_cast<HistogramAggregationConfig>(aggregation_config); |
There was a problem hiding this comment.
Can we use static_pointer_case here, or use dynamic cast only if RTTI macro is enabled. Something similar to what we do here -
There was a problem hiding this comment.
I'm not sure yet if I want to keep the shard_ptr. The main issue was in the lambda that was passing the pointer.
| new opentelemetry::sdk::metrics::HistogramAggregationConfig}; | ||
| static_cast<opentelemetry::sdk::metrics::HistogramAggregationConfig *>(aggregation_config.get()) | ||
| ->boundaries_ = std::list<double>{0.0, 50.0, 100.0, 250.0, 500.0, 750.0, | ||
| 1000.0, 2500.0, 5000.0, 10000.0, 20000.0}; |
There was a problem hiding this comment.
Oh I should have realized these changes to be done while converting boundaries to double. Sorry about that :(
There was a problem hiding this comment.
I just changed them to introduce the crash into our CI :)
ays7
added a commit
to ays7/opentelemetry-cpp
that referenced
this pull request
Oct 29, 2022
…ad-local-stack * commit '9acde87b08b225ce511fa8a20c6cba14f2921518': (36 commits) Prepare v1.7.0 release with Metrics API/SDK GA. (open-telemetry#1721) Fix: 1712 - Validate Instrument meta data (name, unit, description) (open-telemetry#1713) Document libthrift 0.12.0 doesn't work with Jaeger exporter (open-telemetry#1714) Fix:1674, Add Monotonic Property to Sum Aggregation, and unit tests for Up Down Counter (open-telemetry#1675) [Metrics SDK] Move Metrics Exemplar processing behind feature flag (open-telemetry#1710) [Metrics API/SDK] Change Meter API/SDK to return nostd::unique_ptr for Sync Instruments (open-telemetry#1707) [Metrics] Switch to explicit 64 bit integers (open-telemetry#1686) Add metrics e2e test to asan & tsan CI (open-telemetry#1670) Add otlp-grpc example bazel (open-telemetry#1708) [Metrics SDK] Add support for Pull Metric Reader (open-telemetry#1701) Fix debug log of OTLP HTTP exporter and ES log exporter (open-telemetry#1703) [SEMANTIC CONVENTIONS] Upgrade to version 1.14.0 (open-telemetry#1697) Fix a potential precision loss on integer in ReservoirCellIndexFor (open-telemetry#1696) fix Histogram crash (open-telemetry#1685) Fix:1676 Segfault when short export period is used for metrics (open-telemetry#1682) Add timeout support to MeterContext::ForceFlush (open-telemetry#1673) Add CMake OTELCPP_MAINTAINER_MODE (open-telemetry#1650) [DOCS] - Minor updates to OStream Metrics exporter documentation (open-telemetry#1679) Fix:open-telemetry#1575 API Documentation for Metrics SDK and API (open-telemetry#1678) Fixes open-telemetry#249 (open-telemetry#1677) ...
yxue
pushed a commit
to yxue/opentelemetry-cpp
that referenced
this pull request
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1665 (issue)
Changes
One of the
CreateAggregationoverloads was not passing the aggregation config to the histogram ctors. Also replaced nostd withstd::shared_ptr.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes