Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare v1.7.0 release with Metrics API/SDK GA. #1721

Merged
merged 10 commits into from
Oct 28, 2022
Merged

Prepare v1.7.0 release with Metrics API/SDK GA. #1721

merged 10 commits into from
Oct 28, 2022

Conversation

esigo
Copy link
Member

@esigo esigo commented Oct 28, 2022

No description provided.

@esigo esigo requested a review from a team October 28, 2022 16:32
@codecov
Copy link

codecov bot commented Oct 28, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@dd7e257). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1721   +/-   ##
=======================================
  Coverage        ?   85.79%           
=======================================
  Files           ?      171           
  Lines           ?     5212           
  Branches        ?        0           
=======================================
  Hits            ?     4471           
  Misses          ?      741           
  Partials        ?        0

@lalitb
Copy link
Member

lalitb commented Oct 28, 2022

Just to add - This PR is also the meant to be GA release for Metrics API and SDK. If there are PRs or issues which should block this release, comment below and we can discuss further here.

@lalitb lalitb changed the title Prepare v1.7.0 release Prepare v1.7.0 release with Metrics API/SDK GA. Oct 28, 2022
ThomsonTan
ThomsonTan reviewed Oct 28, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@esigo @ThomsonTan
Update CHANGELOG.md
8bd58b9 
Co-authored-by: Tom Tan <[email protected]>
lalitb
lalitb reviewed Oct 28, 2022
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@esigo @lalitb
Update CHANGELOG.md
0273c5d 
Co-authored-by: Lalit Kumar Bhasin <[email protected]>
ThomsonTan
ThomsonTan reviewed Oct 28, 2022
View reviewed changes
CHANGELOG.md Outdated
* [METRICS SDK] Fix data race on MeterContext::meters_ [#1668](https:/open-telemetry/opentelemetry-cpp/pull/1668)
* [METRICS SDK] Fix observable Gauge metrics generation [#1651](https:/open-telemetry/opentelemetry-cpp/pull/1651)
* [BUILD] Detect ARCH=sparc in CMake [#1660](https:/open-telemetry/opentelemetry-cpp/pull/1660)
* Add user agent for OTLP http/grpc client [#1657](https:/open-telemetry/opentelemetry-cpp/pull/1657)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tag here, [SDK]?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, added the tag

ThomsonTan
ThomsonTan reviewed Oct 28, 2022
View reviewed changes
CHANGELOG.md
and change default bucket range [#1626](https:/open-telemetry/opentelemetry-cpp/pull/1626)
* [METRICS SDK] Fix occasional Segfault with LongCounter instrument [#1638](https:/open-telemetry/opentelemetry-cpp/pull/1638)
* [BUILD] Bump vcpk to 2022.08.15 [#1633](https:/open-telemetry/opentelemetry-cpp/pull/1633)
* [BUILD] Bump gRPC to v1.48.1 for CMake Linux CI [#1608](https:/open-telemetry/opentelemetry-cpp/pull/1608)
Copy link
Contributor

@ThomsonTan ThomsonTan Oct 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a notes section on the end to include the breaking changes for metrics preview customers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks added the note:

Notes:

Metrics API/SDK GA release includes PRs #1686, #1701, and #1707 with breaking changes in the Metrics API and SDK.

ThomsonTan
ThomsonTan reviewed Oct 28, 2022
View reviewed changes
sdk/src/version/version.cc Outdated
const char *FULL_VERSION =
"1.6.0-NONE-NONE-27-pre_release_1.6.1-38012fab34faa50d5020959b68eba77ac485b508";
"1.7.0-NONE-NONE-35-pre_release_1.7.0-dd7e257b6de71eeaf9e3149530962301705b9a0d";
const char *BUILD_DATE = "Thu Sep 22 18:05:21 UTC 2022";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buildscripts/pre-commit should update the BUILD_DATE here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, updated

lalitb
lalitb approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, and nicely done - even though it was the first release :)

ThomsonTan
ThomsonTan approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@ThomsonTan ThomsonTan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the format is fixed. Thanks @esigo

marcalff
marcalff approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see comment for changelog.

CHANGELOG.md Outdated
which includes breaking change in the Metrics api and sdk.
* [BUILD] Add e2e test to asan & tsan CI [#1670](https:/open-telemetry/opentelemetry-cpp/pull/1670)
* [BUILD] Add otlp-grpc example bazel [#1708](https:/open-telemetry/opentelemetry-cpp/pull/1708)
* Fix debug log of OTLP HTTP exporter and ES log exporter [#1703](https:/open-telemetry/opentelemetry-cpp/pull/1703)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add [TRACE SDK] for 1703

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, added

@esigo esigo merged commit 9acde87 into open-telemetry:main Oct 28, 2022
@esigo esigo deleted the pre_release_1.7.0 branch October 28, 2022 22:02
ays7 added a commit to ays7/opentelemetry-cpp that referenced this pull request Oct 29, 2022
@ays7
Merge commit '9acde87b08b225ce511fa8a20c6cba14f2921518' into ays/thre…
456a0e7 
…ad-local-stack

* commit '9acde87b08b225ce511fa8a20c6cba14f2921518': (36 commits)
  Prepare v1.7.0 release with Metrics API/SDK GA. (open-telemetry#1721)
  Fix: 1712 -  Validate Instrument meta data (name, unit, description) (open-telemetry#1713)
  Document libthrift 0.12.0 doesn't work with Jaeger exporter (open-telemetry#1714)
  Fix:1674, Add Monotonic Property to Sum Aggregation, and unit tests for Up Down Counter (open-telemetry#1675)
  [Metrics SDK] Move Metrics Exemplar processing behind feature flag (open-telemetry#1710)
  [Metrics API/SDK] Change Meter API/SDK to return nostd::unique_ptr for Sync Instruments (open-telemetry#1707)
  [Metrics] Switch to explicit 64 bit integers (open-telemetry#1686)
  Add metrics e2e test to asan & tsan CI (open-telemetry#1670)
  Add otlp-grpc example bazel (open-telemetry#1708)
  [Metrics SDK] Add support for Pull Metric Reader (open-telemetry#1701)
  Fix debug log of OTLP HTTP exporter and ES log exporter (open-telemetry#1703)
  [SEMANTIC CONVENTIONS] Upgrade to version 1.14.0 (open-telemetry#1697)
  Fix a potential precision loss on integer in ReservoirCellIndexFor (open-telemetry#1696)
  fix Histogram crash (open-telemetry#1685)
  Fix:1676 Segfault when short export period is used for metrics  (open-telemetry#1682)
  Add timeout support to MeterContext::ForceFlush (open-telemetry#1673)
  Add CMake OTELCPP_MAINTAINER_MODE (open-telemetry#1650)
  [DOCS] - Minor updates to OStream Metrics exporter documentation (open-telemetry#1679)
  Fix:open-telemetry#1575 API Documentation for Metrics SDK and API (open-telemetry#1678)
  Fixes open-telemetry#249 (open-telemetry#1677)
  ...
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
@esigo @yxue
Prepare v1.7.0 release with Metrics API/SDK GA. (open-telemetry#1721)
399daf5
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
@esigo @yxue
Prepare v1.7.0 release with Metrics API/SDK GA. (open-telemetry#1721)
c7bd2d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomsonTan ThomsonTan ThomsonTan approved these changes

@lalitb lalitb lalitb approved these changes

@marcalff marcalff marcalff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@esigo @lalitb @ThomsonTan @marcalff