[Feature/extensions]Enforce type safety for RegisterTransportActionsRequest

[mloufra]

Signed-off-by: mloufra [email protected]

Description

Add unbounded wildcard for RegisterTransportActionsRequest constructor to clean up compiler warning
Equivalent PR on OpenSearch-sdk-java: opensearch-project/opensearch-sdk-java#195

Issues Resolved

opensearch-project/opensearch-sdk-java#130

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[dbwiddis]

@mloufra Can you edit your title to add [Feature/extensions] as a prefix so the maintainers know our team is handling it?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/4717/
• CommitID: 47d7276

[codecov-commenter]

Codecov Report

Merging #4796 (f74f20f) into feature/extensions (eee59c5) will increase coverage by 0.09%.
The diff coverage is 76.82%.

@@                   Coverage Diff                    @@
##             feature/extensions    #4796      +/-   ##
========================================================
+ Coverage                 70.52%   70.62%   +0.09%     
+ Complexity                57898    57799      -99     
========================================================
  Files                      4708     4706       -2     
  Lines                    278528   277836     -692     
  Branches                  40661    40389     -272     
========================================================
- Hits                     196420   196208     -212     
+ Misses                    65740    65354     -386     
+ Partials                  16368    16274      -94     

Impacted Files	Coverage Δ
...main/java/org/opensearch/gradle/PublishPlugin.java	43.43% <0.00%> (-0.45%)	⬇️
.../java/org/opensearch/gradle/pluginzip/Publish.java	11.62% <0.00%> (-0.57%)	⬇️
...earch/analysis/common/NGramTokenFilterFactory.java	75.00% <0.00%> (+10.71%)	⬆️
...gregations/bucket/geogrid/BucketPriorityQueue.java	75.00% <ø> (ø)
...arch/aggregations/bucket/geogrid/CellIdSource.java	69.23% <ø> (ø)
...ions/bucket/geogrid/GeoGridAggregationBuilder.java	75.67% <ø> (ø)
.../bucket/geogrid/GeoHashGridAggregationBuilder.java	100.00% <ø> (ø)
.../bucket/geogrid/GeoTileGridAggregationBuilder.java	100.00% <ø> (ø)
...ions/bucket/geogrid/InternalGeoHashGridBucket.java	100.00% <ø> (ø)
...ions/bucket/geogrid/InternalGeoTileGridBucket.java	100.00% <ø> (ø)
... and 691 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[dbwiddis]

We generally put the feature/extensions tag at the beginning of the title. A more descriptive title than "Compiler Warning" might be helpful, such as "Enforce type safety for RegisterTransportActionsRequest".

Also per CI checks you need a change log.

[dbwiddis]

This is called from the SDK with this line:

new RegisterTransportActionsRequest(uniqueId, transportActions),

See comment here for narrower types needed.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/4813/
• CommitID: 60ad8b9

[owaiskazi19]

@mloufra you need to make the changes in test files as well

/home/runner/work/OpenSearch/OpenSearch/server/src/test/java/org/opensearch/extensions/RegisterTransportActionsRequestTests.java:24: error: incompatible types: inference variable V has incompatible bounds
        this.originalRequest = new RegisterTransportActionsRequest("extension-uniqueId", Map.of("testAction", Map.class));
> Task :server:compileTestJava
                               ^
    equality constraints: Class<? extends TransportAction<? extends ActionRequest,? extends ActionResponse>>
    lower bounds: Class<org.opensearch.common.collect.Map>
  where V,K are type-variables:
    V extends Object declared in method <K,V>of(K,V)
    K extends Object declared in method <K,V>of(K,V)
/home/runner/work/OpenSearch/OpenSearch/server/src/test/java/org/opensearch/extensions/action/ExtensionTransportActionsHandlerTests.java:132: error: incompatible types: inference variable V has incompatible bounds
        RegisterTransportActionsRequest request = new RegisterTransportActionsRequest(

[mloufra]

@mloufra you need to make the changes in test files as well

/home/runner/work/OpenSearch/OpenSearch/server/src/test/java/org/opensearch/extensions/RegisterTransportActionsRequestTests.java:24: error: incompatible types: inference variable V has incompatible bounds
        this.originalRequest = new RegisterTransportActionsRequest("extension-uniqueId", Map.of("testAction", Map.class));
> Task :server:compileTestJava
                               ^
    equality constraints: Class<? extends TransportAction<? extends ActionRequest,? extends ActionResponse>>
    lower bounds: Class<org.opensearch.common.collect.Map>
  where V,K are type-variables:
    V extends Object declared in method <K,V>of(K,V)
    K extends Object declared in method <K,V>of(K,V)
/home/runner/work/OpenSearch/OpenSearch/server/src/test/java/org/opensearch/extensions/action/ExtensionTransportActionsHandlerTests.java:132: error: incompatible types: inference variable V has incompatible bounds
        RegisterTransportActionsRequest request = new RegisterTransportActionsRequest(

Thanks for the reminder, I'm trying to fix this.

[dbwiddis]

Changes here look good, per other comment need to also update test files.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/5133/
• CommitID: 8750132

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/5208/
• CommitID: f74f20f