Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler warning #195

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Conversation

mloufra
Copy link
Contributor

@mloufra mloufra commented Oct 14, 2022

Signed-off-by: mloufra [email protected]

Description

Add Add unbounded wildcard for transportActions in TransportActions.java to clean up compiler warning.
Equivalent PR on OpenSearch: opensearch-project/OpenSearch#4796

Issues Resolved

#130

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@owaiskazi19
Copy link
Member

@mloufra can you rebase your branch with latest main and push the changes?

@dbwiddis
Copy link
Member

Awaiting merging of companion PR

@codecov-commenter
Copy link

Codecov Report

Merging #195 (209ff63) into main (ad33614) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #195   +/-   ##
=========================================
  Coverage     66.45%   66.45%           
  Complexity      101      101           
=========================================
  Files            25       25           
  Lines           480      480           
  Branches         18       18           
=========================================
  Hits            319      319           
  Misses          148      148           
  Partials         13       13           
Impacted Files Coverage Δ
...main/java/org/opensearch/sdk/TransportActions.java 81.81% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@saratvemulapalli saratvemulapalli merged commit cf542d3 into opensearch-project:main Oct 21, 2022
@mloufra mloufra deleted the compilerwarning branch October 21, 2022 19:33
kokibas pushed a commit to kokibas/opensearch-sdk-java that referenced this pull request Mar 17, 2023
* clean up compiler warning

Signed-off-by: mloufra <[email protected]>

* add type for transportAction

Signed-off-by: mloufra <[email protected]>

Signed-off-by: mloufra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants