Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROB: Cope with invalid objects in IndirectObject.clone #1637

Merged
merged 2 commits into from
Feb 25, 2023

Conversation

pubpub-zz
Copy link
Collaborator

fixes #1631

cope with invalid pdf files where an object can not be found

fixes py-pdf#1631

cope with invalid pdf files where an object can not be found
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 92.25% // Head: 92.25% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (8f19143) compared to base (14b61ea).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1637   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files          33       33           
  Lines        6431     6434    +3     
  Branches     1286     1287    +1     
=======================================
+ Hits         5933     5936    +3     
  Misses        315      315           
  Partials      183      183           
Impacted Files Coverage Δ
pypdf/generic/_base.py 99.65% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pubpub-zz
Copy link
Collaborator Author

Just reminder

@MartinThoma MartinThoma changed the title ROB : cope with invalid objects ROB: Cope with invalid objects in IndirectObject.clone Feb 25, 2023
@MartinThoma MartinThoma merged commit b14dabb into py-pdf:main Feb 25, 2023
@MartinThoma
Copy link
Member

@pubpub-zz Thank you for the reminder and for the PR 🤗

MartinThoma added a commit that referenced this pull request Feb 26, 2023
New Features (ENH)
-  Add reader.attachments public interface (#1611, #1661)
-  Add PdfWriter.remove_objects_from_page(page: PageObject, to_delete: ObjectDeletionFlag) (#1648)
-  Allow free-text annotation to have transparent border/background (#1664)

Bug Fixes (BUG)
-  Allow decryption with empty password for AlgV5 (#1663)
-  Let PdfWriter.pages return PageObject after calling `clone_document_from_reader()` (#1613)
-  Invalid font pointed during merge_resources (#1641)

Robustness (ROB)
-  Cope with invalid objects in IndirectObject.clone (#1637)
-  Improve tolerance to invalid Names/Dests (#1658)
-  Decode encoded values in get_fields (#1636)
-  Let PdfWriter.merge cope with missing "/Fields" (#1628)

[Full Changelog](3.4.1...3.5.0)
@pubpub-zz pubpub-zz deleted the iss1631 branch June 24, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

writer.append() assertion error
2 participants