Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Allow free-text annotation to have transparent border/background #1664

Merged
merged 1 commit into from
Feb 26, 2023

Conversation

MartinThoma
Copy link
Member

No description provided.

@MartinThoma MartinThoma force-pushed the allow-transparent-background-annotation branch from 7b7eec5 to acdfdc2 Compare February 26, 2023 12:02
@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Base: 92.25% // Head: 92.26% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (acdfdc2) compared to base (14b61ea).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1664   +/-   ##
=======================================
  Coverage   92.25%   92.26%           
=======================================
  Files          33       33           
  Lines        6431     6439    +8     
  Branches     1286     1290    +4     
=======================================
+ Hits         5933     5941    +8     
  Misses        315      315           
  Partials      183      183           
Impacted Files Coverage Δ
pypdf/generic/_annotations.py 97.75% <100.00%> (+0.13%) ⬆️
pypdf/generic/_base.py 99.65% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MartinThoma MartinThoma merged commit 44bc1fc into main Feb 26, 2023
@MartinThoma MartinThoma deleted the allow-transparent-background-annotation branch February 26, 2023 12:12
@MartinThoma MartinThoma added the is-feature A feature request label Feb 26, 2023
MartinThoma added a commit that referenced this pull request Feb 26, 2023
New Features (ENH)
-  Add reader.attachments public interface (#1611, #1661)
-  Add PdfWriter.remove_objects_from_page(page: PageObject, to_delete: ObjectDeletionFlag) (#1648)
-  Allow free-text annotation to have transparent border/background (#1664)

Bug Fixes (BUG)
-  Allow decryption with empty password for AlgV5 (#1663)
-  Let PdfWriter.pages return PageObject after calling `clone_document_from_reader()` (#1613)
-  Invalid font pointed during merge_resources (#1641)

Robustness (ROB)
-  Cope with invalid objects in IndirectObject.clone (#1637)
-  Improve tolerance to invalid Names/Dests (#1658)
-  Decode encoded values in get_fields (#1636)
-  Let PdfWriter.merge cope with missing "/Fields" (#1628)

[Full Changelog](3.4.1...3.5.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is-feature A feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant