ENH: Add reader.attachments public interface #1661
Conversation
|
@pubpub-zz What do you think about this public interface to the _get_attachments / _list_attachments methods? |
|
I'm not sure if I like the LazyLoader. I would like to hide this lazy-loading behaviour. Essentially only load it, if the key of the dictionary is accessed (while still keeping it a standard dictionary with the @MasterOdin do you maybe have an idea? edit: https://stackoverflow.com/a/47212782/562769 might be working 🤔 |
Codecov ReportBase: 92.26% // Head: 92.28% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1661 +/- ##
==========================================
+ Coverage 92.26% 92.28% +0.02%
==========================================
Files 33 33
Lines 6439 6457 +18
Branches 1290 1292 +2
==========================================
+ Hits 5941 5959 +18
Misses 315 315
Partials 183 183
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
MartinThoma
force-pushed
the
attachments-interface
branch
from
e2dafc5
to
84a852b
Compare
|
@pubpub-zz what do you think about this pr? |
|
All good for me! 👏 |
|
Nice! I also just understood your comment - I had initially a worse interface that was still in the top of the PR. I've adjusted the message in the top :-) |
New Features (ENH) - Add reader.attachments public interface (#1611, #1661) - Add PdfWriter.remove_objects_from_page(page: PageObject, to_delete: ObjectDeletionFlag) (#1648) - Allow free-text annotation to have transparent border/background (#1664) Bug Fixes (BUG) - Allow decryption with empty password for AlgV5 (#1663) - Let PdfWriter.pages return PageObject after calling `clone_document_from_reader()` (#1613) - Invalid font pointed during merge_resources (#1641) Robustness (ROB) - Cope with invalid objects in IndirectObject.clone (#1637) - Improve tolerance to invalid Names/Dests (#1658) - Decode encoded values in get_fields (#1636) - Let PdfWriter.merge cope with missing "/Fields" (#1628) [Full Changelog](3.4.1...3.5.0)
Add
PdfReader.attachments -> Mapping[str, List[bytes]]as a public interface.The heavy-lifting was done by @pubpub-zz in #1611