Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e2e]: nodejs tag main default slsa3 #2290

Closed
ianlewis opened this issue Jun 14, 2023 · 7 comments · Fixed by #2316
Closed

[e2e]: nodejs tag main default slsa3 #2290

ianlewis opened this issue Jun 14, 2023 · 7 comments · Fixed by #2316
Labels
area:nodejs Issue related to the Node.js builder e2e e2e integration tests type:bug Something isn't working

Comments

@ianlewis
Copy link
Member

Repo: https:/slsa-framework/example-package/tree/main
Run: https:/slsa-framework/example-package/actions/runs/5263664778
Workflow file: https:/slsa-framework/example-package/tree/main/.github/workflows/e2e.nodejs.tag.main.default.slsa3.yml
Workflow runs: https:/slsa-framework/example-package/actions/workflows/e2e.nodejs.tag.main.default.slsa3.yml
Trigger: schedule
Branch: main
Date: Wed Jun 14 06:09:57 UTC 2023
@ianlewis ianlewis added e2e e2e integration tests type:bug Something isn't working area:nodejs Issue related to the Node.js builder labels Jun 14, 2023
@ianlewis
Copy link
Member Author

Repo: https:/slsa-framework/example-package/tree/main
Run: https:/slsa-framework/example-package/actions/runs/5275400917
Workflow file: https:/slsa-framework/example-package/tree/main/.github/workflows/e2e.nodejs.tag.main.default.slsa3.yml
Workflow runs: https:/slsa-framework/example-package/actions/workflows/e2e.nodejs.tag.main.default.slsa3.yml
Trigger: schedule
Branch: main
Date: Thu Jun 15 06:10:20 UTC 2023

@ianlewis
Copy link
Member Author

Repo: https:/slsa-framework/example-package/tree/main
Run: https:/slsa-framework/example-package/actions/runs/5286807508
Workflow file: https:/slsa-framework/example-package/tree/main/.github/workflows/e2e.nodejs.tag.main.default.slsa3.yml
Workflow runs: https:/slsa-framework/example-package/actions/workflows/e2e.nodejs.tag.main.default.slsa3.yml
Trigger: schedule
Branch: main
Date: Fri Jun 16 06:09:48 UTC 2023

@ianlewis
Copy link
Member Author

Repo: https:/slsa-framework/example-package/tree/main
Run: https:/slsa-framework/example-package/actions/runs/5296700245
Workflow file: https:/slsa-framework/example-package/tree/main/.github/workflows/e2e.nodejs.tag.main.default.slsa3.yml
Workflow runs: https:/slsa-framework/example-package/actions/workflows/e2e.nodejs.tag.main.default.slsa3.yml
Trigger: schedule
Branch: main
Date: Sat Jun 17 06:09:16 UTC 2023

@ianlewis
Copy link
Member Author

Repo: https:/slsa-framework/example-package/tree/main
Run: https:/slsa-framework/example-package/actions/runs/5302135362
Workflow file: https:/slsa-framework/example-package/tree/main/.github/workflows/e2e.nodejs.tag.main.default.slsa3.yml
Workflow runs: https:/slsa-framework/example-package/actions/workflows/e2e.nodejs.tag.main.default.slsa3.yml
Trigger: schedule
Branch: main
Date: Sun Jun 18 06:08:44 UTC 2023

@ianlewis
Copy link
Member Author

Repo: https:/slsa-framework/example-package/tree/main
Run: https:/slsa-framework/example-package/actions/runs/5308437900
Workflow file: https:/slsa-framework/example-package/tree/main/.github/workflows/e2e.nodejs.tag.main.default.slsa3.yml
Workflow runs: https:/slsa-framework/example-package/actions/workflows/e2e.nodejs.tag.main.default.slsa3.yml
Trigger: schedule
Branch: main
Date: Mon Jun 19 06:10:30 UTC 2023

@ianlewis ianlewis added this to the Node.js builder GA milestone Jun 19, 2023
@ianlewis
Copy link
Member Author

Repo: https:/slsa-framework/example-package/tree/main
Run: https:/slsa-framework/example-package/actions/runs/5319128822
Workflow file: https:/slsa-framework/example-package/tree/main/.github/workflows/e2e.nodejs.tag.main.default.slsa3.yml
Workflow runs: https:/slsa-framework/example-package/actions/workflows/e2e.nodejs.tag.main.default.slsa3.yml
Trigger: schedule
Branch: main
Date: Tue Jun 20 06:11:01 UTC 2023

@ianlewis ianlewis mentioned this issue Jun 21, 2023
Merged
@ianlewis
Copy link
Member Author

Repo: https:/slsa-framework/example-package/tree/main
Run: https:/slsa-framework/example-package/actions/runs/5330700540
Workflow file: https:/slsa-framework/example-package/tree/main/.github/workflows/e2e.nodejs.tag.main.default.slsa3.yml
Workflow runs: https:/slsa-framework/example-package/actions/workflows/e2e.nodejs.tag.main.default.slsa3.yml
Trigger: schedule
Branch: main
Date: Wed Jun 21 06:09:42 UTC 2023

ianlewis added a commit that referenced this issue Jun 21, 2023
@ianlewis
fix: getting npm pack filename (#2316)
01daa2e 
Fixes getting the filename from the result of `npm pack --json`. Some
older versions return the incorrect file name.

This change falls back and attempts to determine the filename if the
file is not initially found.

Fixes #2290  #2294 #2295 #2296 #2297 #2298 #2299

Signed-off-by: Ian Lewis <[email protected]>
enteraga6 pushed a commit to enteraga6/slsa-github-generator that referenced this issue Jul 7, 2023
@ianlewis @enteraga6
fix: getting npm pack filename (slsa-framework#2316)
8783006 
Fixes getting the filename from the result of `npm pack --json`. Some
older versions return the incorrect file name.

This change falls back and attempts to determine the filename if the
file is not initially found.

Fixes slsa-framework#2290  slsa-framework#2294 slsa-framework#2295 slsa-framework#2296 slsa-framework#2297 slsa-framework#2298 slsa-framework#2299

Signed-off-by: Ian Lewis <[email protected]>
Signed-off-by: Noah Elzner <[email protected]>
@ianlewis ianlewis removed this from the Node.js builder GA milestone Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:nodejs Issue related to the Node.js builder e2e e2e integration tests type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: getting npm pack filename ianlewis/slsa-github-generator
1 participant
@ianlewis