fix: getting npm pack filename #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Lewis <[email protected]>
laurentsimon
approved these changes
Jun 21, 2023
enteraga6
pushed a commit
to enteraga6/slsa-github-generator
that referenced
this pull request
Jul 7, 2023
Fixes getting the filename from the result of `npm pack --json`. Some older versions return the incorrect file name. This change falls back and attempts to determine the filename if the file is not initially found. Fixes slsa-framework#2290 slsa-framework#2294 slsa-framework#2295 slsa-framework#2296 slsa-framework#2297 slsa-framework#2298 slsa-framework#2299 Signed-off-by: Ian Lewis <[email protected]> Signed-off-by: Noah Elzner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes getting the filename from the result of
npm pack --json. Some older versions return the incorrect file name.This change falls back and attempts to determine the filename if the file is not initially found.
Fixes #2290 #2294 #2295 #2296 #2297 #2298 #2299