Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e2e]: nodejs create main default slsa3 #2298

Closed
ianlewis opened this issue Jun 15, 2023 · 10 comments
Closed

[e2e]: nodejs create main default slsa3 #2298

ianlewis opened this issue Jun 15, 2023 · 10 comments
Labels
area:nodejs Issue related to the Node.js builder e2e e2e integration tests type:bug Something isn't working

Comments

@ianlewis
Copy link
Member

Repo: https:/slsa-framework/example-package/tree/v39.0.17
Run: https:/slsa-framework/example-package/actions/runs/5275498315
Workflow file: https:/slsa-framework/example-package/tree/main/.github/workflows/e2e.nodejs.create.main.default.slsa3.yml
Workflow runs: https:/slsa-framework/example-package/actions/workflows/e2e.nodejs.create.main.default.slsa3.yml
Trigger: create
Branch: v39.0.17
Date: Thu Jun 15 06:23:42 UTC 2023
@ianlewis ianlewis added e2e e2e integration tests type:bug Something isn't working area:nodejs Issue related to the Node.js builder labels Jun 15, 2023
@ianlewis
Copy link
Member Author

Repo: https:/slsa-framework/example-package/tree/v39.0.18
Run: https:/slsa-framework/example-package/actions/runs/5286902957
Workflow file: https:/slsa-framework/example-package/tree/main/.github/workflows/e2e.nodejs.create.main.default.slsa3.yml
Workflow runs: https:/slsa-framework/example-package/actions/workflows/e2e.nodejs.create.main.default.slsa3.yml
Trigger: create
Branch: v39.0.18
Date: Fri Jun 16 06:24:28 UTC 2023

@ianlewis
Copy link
Member Author

Repo: https:/slsa-framework/example-package/tree/v39.0.19
Run: https:/slsa-framework/example-package/actions/runs/5296758191
Workflow file: https:/slsa-framework/example-package/tree/main/.github/workflows/e2e.nodejs.create.main.default.slsa3.yml
Workflow runs: https:/slsa-framework/example-package/actions/workflows/e2e.nodejs.create.main.default.slsa3.yml
Trigger: create
Branch: v39.0.19
Date: Sat Jun 17 06:23:12 UTC 2023

@ianlewis
Copy link
Member Author

Repo: https:/slsa-framework/example-package/tree/v39.0.20
Run: https:/slsa-framework/example-package/actions/runs/5302194675
Workflow file: https:/slsa-framework/example-package/tree/main/.github/workflows/e2e.nodejs.create.main.default.slsa3.yml
Workflow runs: https:/slsa-framework/example-package/actions/workflows/e2e.nodejs.create.main.default.slsa3.yml
Trigger: create
Branch: v39.0.20
Date: Sun Jun 18 06:23:37 UTC 2023

@ianlewis
Copy link
Member Author

Repo: https:/slsa-framework/example-package/tree/v39.0.21
Run: https:/slsa-framework/example-package/actions/runs/5308541916
Workflow file: https:/slsa-framework/example-package/tree/main/.github/workflows/e2e.nodejs.create.main.default.slsa3.yml
Workflow runs: https:/slsa-framework/example-package/actions/workflows/e2e.nodejs.create.main.default.slsa3.yml
Trigger: create
Branch: v39.0.21
Date: Mon Jun 19 06:26:05 UTC 2023

@ianlewis ianlewis added this to the Node.js builder GA milestone Jun 19, 2023
@ianlewis
Copy link
Member Author

Repo: https:/slsa-framework/example-package/tree/v39.0.22
Run: https:/slsa-framework/example-package/actions/runs/5319230557
Workflow file: https:/slsa-framework/example-package/tree/main/.github/workflows/e2e.nodejs.create.main.default.slsa3.yml
Workflow runs: https:/slsa-framework/example-package/actions/workflows/e2e.nodejs.create.main.default.slsa3.yml
Trigger: create
Branch: v39.0.22
Date: Tue Jun 20 12:31:16 UTC 2023

@ianlewis ianlewis mentioned this issue Jun 21, 2023
Merged
@ianlewis
Copy link
Member Author

Repo: https:/slsa-framework/example-package/tree/v39.0.23
Run: https:/slsa-framework/example-package/actions/runs/5330799233
Workflow file: https:/slsa-framework/example-package/tree/main/.github/workflows/e2e.nodejs.create.main.default.slsa3.yml
Workflow runs: https:/slsa-framework/example-package/actions/workflows/e2e.nodejs.create.main.default.slsa3.yml
Trigger: create
Branch: v39.0.23
Date: Wed Jun 21 06:24:48 UTC 2023

ianlewis added a commit that referenced this issue Jun 21, 2023
@ianlewis
fix: getting npm pack filename (#2316)
01daa2e 
Fixes getting the filename from the result of `npm pack --json`. Some
older versions return the incorrect file name.

This change falls back and attempts to determine the filename if the
file is not initially found.

Fixes #2290  #2294 #2295 #2296 #2297 #2298 #2299

Signed-off-by: Ian Lewis <[email protected]>
@ianlewis
Copy link
Member Author

Repo: https:/slsa-framework/example-package/tree/v39.0.24
Run: https:/slsa-framework/example-package/actions/runs/5342301285
Workflow file: https:/slsa-framework/example-package/tree/main/.github/workflows/e2e.nodejs.create.main.default.slsa3.yml
Workflow runs: https:/slsa-framework/example-package/actions/workflows/e2e.nodejs.create.main.default.slsa3.yml
Trigger: create
Branch: v39.0.24
Date: Thu Jun 22 06:25:38 UTC 2023

@ianlewis
Copy link
Member Author

Repo: https:/slsa-framework/example-package/tree/v39.0.25
Run: https:/slsa-framework/example-package/actions/runs/5353515129
Workflow file: https:/slsa-framework/example-package/tree/main/.github/workflows/e2e.nodejs.create.main.default.slsa3.yml
Workflow runs: https:/slsa-framework/example-package/actions/workflows/e2e.nodejs.create.main.default.slsa3.yml
Trigger: create
Branch: v39.0.25
Date: Fri Jun 23 06:28:48 UTC 2023

@ianlewis
Copy link
Member Author

Repo: https:/slsa-framework/example-package/tree/v39.0.26
Run: https:/slsa-framework/example-package/actions/runs/5362993010
Workflow file: https:/slsa-framework/example-package/tree/main/.github/workflows/e2e.nodejs.create.main.default.slsa3.yml
Workflow runs: https:/slsa-framework/example-package/actions/workflows/e2e.nodejs.create.main.default.slsa3.yml
Trigger: create
Branch: v39.0.26
Date: Sat Jun 24 06:27:09 UTC 2023

@ianlewis
Copy link
Member Author

Repo: https:/slsa-framework/example-package/tree/v39.0.27
Run: https:/slsa-framework/example-package/actions/runs/5374560328
Workflow file: https:/slsa-framework/example-package/tree/main/.github/workflows/e2e.nodejs.create.main.default.slsa3.yml
Workflow runs: https:/slsa-framework/example-package/actions/workflows/e2e.nodejs.create.main.default.slsa3.yml
Trigger: create
Branch: v39.0.27
Date: Mon Jun 26 06:33:02 UTC 2023

Tests are passing now. Closing this issue.

enteraga6 pushed a commit to enteraga6/slsa-github-generator that referenced this issue Jul 7, 2023
@ianlewis @enteraga6
fix: getting npm pack filename (slsa-framework#2316)
8783006 
Fixes getting the filename from the result of `npm pack --json`. Some
older versions return the incorrect file name.

This change falls back and attempts to determine the filename if the
file is not initially found.

Fixes slsa-framework#2290  slsa-framework#2294 slsa-framework#2295 slsa-framework#2296 slsa-framework#2297 slsa-framework#2298 slsa-framework#2299

Signed-off-by: Ian Lewis <[email protected]>
Signed-off-by: Noah Elzner <[email protected]>
@ianlewis ianlewis removed this from the Node.js builder GA milestone Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:nodejs Issue related to the Node.js builder e2e e2e integration tests type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ianlewis