System Test: Module (WAZUH-DB) - Sync of agents registered on nodes after seconds #2761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CamiRomero
suggested changes
Apr 11, 2022
Comment on lines
6
to
7
| brief: This tests check that when a cluster has a series of agents registered and connecting one after the other, | ||
| and it is unable to do a Sync, that after a expected time, a Sync is forced and the DB is Synched. |
There was a problem hiding this comment.
Suggested change
| brief: This tests check that when a cluster has a series of agents registered and connecting one after the other, | |
| and it is unable to do a Sync, that after a expected time, a Sync is forced and the DB is Synched. | |
| brief: These tests check that when a cluster has a series of agents registered and connecting one after the other, | |
| and it is unable to do a Sync, that after an expected time, a Sync is forced and the DB is Synched. |
| parameters: | ||
| - agent_host: | ||
| type: List | ||
| brief: name of the host where the agent will register en each case |
There was a problem hiding this comment.
Suggested change
| brief: name of the host where the agent will register en each case | |
| brief: name of the host where the agent will register in each case |
Comment on lines
68
to
70
| @pytest.mark.parametrize("test_infra_managers",[test_infra_managers]) | ||
| @pytest.mark.parametrize("test_infra_agents",[test_infra_agents]) | ||
| @pytest.mark.parametrize("host_manager",[host_manager]) |
There was a problem hiding this comment.
Add space after comma in order to follow pycodestyle
Suggested change
| @pytest.mark.parametrize("test_infra_managers",[test_infra_managers]) | |
| @pytest.mark.parametrize("test_infra_agents",[test_infra_agents]) | |
| @pytest.mark.parametrize("host_manager",[host_manager]) | |
| @pytest.mark.parametrize("test_infra_managers", [test_infra_managers]) | |
| @pytest.mark.parametrize("test_infra_agents", [test_infra_agents]) | |
| @pytest.mark.parametrize("host_manager", [host_manager]) |
| test_infra_managers = ["wazuh-master", "wazuh-worker1", "wazuh-worker2"] | ||
| agents_in_cluster = 40 | ||
| test_infra_agents=[] | ||
| for x in range(agents_in_cluster): |
There was a problem hiding this comment.
Remove space at the end of the line in order to follow pycodestyle
Suggested change
| for x in range(agents_in_cluster): | |
| for x in range(agents_in_cluster): |
| # Hosts | ||
| test_infra_managers = ["wazuh-master", "wazuh-worker1", "wazuh-worker2"] | ||
| agents_in_cluster = 40 | ||
| test_infra_agents=[] |
There was a problem hiding this comment.
Add space before and after equal symbol in order to follow pycodestyle
Suggested change
| test_infra_agents=[] | |
| test_infra_agents = [] |
| ''' | ||
| description: Check that after a long time when the manager has been unable to synchronize de databases, because | ||
| new agents are being continually added, database synchronization is forced and the expected information is in | ||
| all nodes after the expected sync time. For this, an agent is restarted and connects to the agent every roughly 10 |
There was a problem hiding this comment.
Remove space at the end of line in order to follow pycodestyle
Suggested change
| all nodes after the expected sync time. For this, an agent is restarted and connects to the agent every roughly 10 | |
| all nodes after the expected sync time. For this, an agent is restarted and connects to the agent every roughly 10 |
| ''' | ||
|
|
||
| # Register agents in manager | ||
| agent_data=[] |
There was a problem hiding this comment.
Add space before and after equal symbol in order to follow pycodestyle
Suggested change
| agent_data=[] | |
| agent_data = [] |
| while time.time() < end_time: | ||
| if active_agent < agents_in_cluster: | ||
| host_manager.run_command(test_infra_agents[active_agent], f'{WAZUH_PATH}/bin/wazuh-control start') | ||
| active_agent = active_agent +1 |
There was a problem hiding this comment.
missing whitespace around the operator
Suggested change
| active_agent = active_agent +1 | |
| active_agent = active_agent + 1 |
Tests Results
|
CamiRomero
approved these changes
Apr 11, 2022
13 tasks
15 tasks
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR the test suite for
test_groups_sync_default.pyis added. A total of 2 new test cases cover that when having a cluster, and a series of agents is registered over time, the group data is synchronized as expected.Cases:
- Forty agents are registered to
masterand they have the default group assigned in theclusterConfiguration options
In order to run the test, first the environment located in
/test/system/provisioning/big_cluster_40_agentsmust be enabled with:sudo ansible-playbook -i inventory.yml playbook.yml --extra-vars='{"wazuh_branch": "dev-10771-agent-groups-files-to-wazuh-db"}'Local Internal Options: No Local Internal Options used
Tests Results
pycodestyle --max-line-length=120 --show-source --show-pep8 file.py.