3 ➡️ 4

[chapulina]

No description provided.

[codecov]

Codecov Report

Merging #101 into master will increase coverage by 49.50%.
The diff coverage is 77.64%.

@@             Coverage Diff             @@
##           master     #101       +/-   ##
===========================================
+ Coverage   13.83%   63.34%   +49.50%     
===========================================
  Files          14       19        +5     
  Lines        1409     2256      +847     
===========================================
+ Hits          195     1429     +1234     
+ Misses       1214      827      -387     

Impacted Files	Coverage Δ
src/plugins/scene3d/Scene3D.cc	12.78% <0.00%> (ø)
src/plugins/key_publisher/KeyPublisher.cc	56.52% <56.52%> (ø)
src/plugins/topic_viewer/TopicViewer.cc	82.63% <82.63%> (ø)
include/ignition/gui/GuiEvents.hh	0.00% <0.00%> (ø)
src/plugins/topic_echo/TopicEcho.cc	30.50% <0.00%> (ø)
src/ign.cc	37.83% <0.00%> (+37.83%)	⬆️
src/Plugin.cc	60.27% <0.00%> (+60.27%)	⬆️
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a946683...fdf8618. Read the comment docs.

[JShep1]

LGTM, all tests passing, I get a few remarks from codecheck:

[/home/john/dome_ws/src/ign-gui/src/plugins/publisher/Publisher_TEST.cc:142]: (information) Unmatched suppression: knownConditionTrueFalse
[/home/john/dome_ws/src/ign-gui/src/plugins/publisher/Publisher_TEST.cc:174]: (information) Unmatched suppression: knownConditionTrueFalse
/home/john/dome_ws/src/ign-gui/src/plugins/key_publisher/KeyPublisher.hh:55:  Add #include <memory> for unique_ptr<>  [build/include_what_you_use] [4]

Should we resolve these or were these pre-existing?

[Sarath18]

In case you missed it, we should incorporate changes from #102 as we are introducing KeyPublisher and Minimize GUI plugins to ign-gui4 in this PR.

[chapulina]

we should incorporate changes from #102

Done in f21238d

codecheck

Depending on the version of codecheck we may get different warnings, so at the moment, we're trying to satisfy the version on CI (it runs on actions and Jenkins for Ubuntu), which is currently happy. But in any case, I fixed the missing include in
f36ce44 . The unmatched suppression are trickier though 😕

[JShep1]

Depending on the version of codecheck

Perhaps it's time I update 🤔

[chapulina]

Perhaps it's time I update

I suspect you may have a newer version 🧐 The one on CI didn't catch the missing include