-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix filtering of not applicable
SCA checks using result
filter
#5031
Fix filtering of not applicable
SCA checks using result
filter
#5031
Conversation
…t and remove the `status` filter in the search bar
… result was falsy. Now it uses the result value.
…ecks-using-result-property
…ecks-using-result-property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ecks-using-result-property
…ecks-using-result-property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: ✅
TEST: ✅
…ecks-using-result-property
bf7fbb4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: ✅
TEST: ✅
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.16 4.4-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.16
# Create a new branch
git switch --create backport-5031-to-4.4-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dd81bc669e6d2748a7b17a41b104557da339f327
# Push it to GitHub
git push --set-upstream origin backport-5031-to-4.4-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.16 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.10 4.4-7.10
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.10
# Create a new branch
git switch --create backport-5031-to-4.4-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dd81bc669e6d2748a7b17a41b104557da339f327
# Push it to GitHub
git push --set-upstream origin backport-5031-to-4.4-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.10 Then, create a pull request where the |
…5031) * fix(sca): change the filter of not applicable SCA checks to use result and remove the `status` filter in the search bar * fix(sca): sort the filters keys in the suggestions of the SCA checks search bar * changelog: add the pull request entry * fix(sca): remove hardcoded `Not applicable` string when the SCA check result was falsy. Now it uses the result value. * fix: unify the SCA check result label name * changelog: add pull request entry * fix: update the API data (endpoints and security actions) Co-authored-by: Ian Yenien Serrano <[email protected]> Co-authored-by: Chantal Belén kelm <[email protected]> (cherry picked from commit dd81bc6)
…5031) * fix(sca): change the filter of not applicable SCA checks to use result and remove the `status` filter in the search bar * fix(sca): sort the filters keys in the suggestions of the SCA checks search bar * changelog: add the pull request entry * fix(sca): remove hardcoded `Not applicable` string when the SCA check result was falsy. Now it uses the result value. * fix: unify the SCA check result label name * changelog: add pull request entry * fix: update the API data (endpoints and security actions) Co-authored-by: Ian Yenien Serrano <[email protected]> Co-authored-by: Chantal Belén kelm <[email protected]> (cherry picked from commit dd81bc6)
… `result` filter (#5083) Fix filtering of `not applicable` SCA checks using `result` filter (#5031) * fix(sca): change the filter of not applicable SCA checks to use result and remove the `status` filter in the search bar * fix(sca): sort the filters keys in the suggestions of the SCA checks search bar * changelog: add the pull request entry * fix(sca): remove hardcoded `Not applicable` string when the SCA check result was falsy. Now it uses the result value. * fix: unify the SCA check result label name * changelog: add pull request entry * fix: update the API data (endpoints and security actions) Co-authored-by: Ian Yenien Serrano <[email protected]> Co-authored-by: Chantal Belén kelm <[email protected]> (cherry picked from commit dd81bc6) Co-authored-by: Antonio <[email protected]>
…g `result` filter (#5082) Fix filtering of `not applicable` SCA checks using `result` filter (#5031) * fix(sca): change the filter of not applicable SCA checks to use result and remove the `status` filter in the search bar * fix(sca): sort the filters keys in the suggestions of the SCA checks search bar * changelog: add the pull request entry * fix(sca): remove hardcoded `Not applicable` string when the SCA check result was falsy. Now it uses the result value. * fix: unify the SCA check result label name * changelog: add pull request entry * fix: update the API data (endpoints and security actions) Co-authored-by: Ian Yenien Serrano <[email protected]> Co-authored-by: Chantal Belén kelm <[email protected]> (cherry picked from commit dd81bc6) Co-authored-by: Antonio <[email protected]>
Description
This PR:
not applicable
SCA checks to useresult
filter instead ofstatus
status
filter suggestion of the SCA checks search barIssues Resolved
Closes #5027
Evidence
Unify SCA check result label name
Filter in the search bar
Suggestions in the search bar
Test
status
andresult
properties.Patch for imposter:
wazuh-kibana-app-pr-5031-imposter.txt
The scenarios could use a Wazuh manger built from the
[dev-sca-policy-checks-result](https:/wazuh/wazuh/tree/dev-sca-policy-checks-result)
branch.Scenario 1 The
Not applicable
kpi filters byresult: not applicable
in the SCA checksGiven a SCA policy with not applicable checks
When the user clicks on the
Not applicable
statThen a
result: not applicable
filter is added to the search barAnd the table should fetch the data whose SCA checks are not applicable and display them
Scenario 2 The SCA checks suggestions should not display the
status
filter keyWhen the user clicks on the search bar
Then the
status
filter should not be displayedScenario 3 The SCA checks filter keys should be sorted alphabetically
When the user clicks on the search bar
Then the filter keys should be sorted alphabetically
Scenario 4 The kpis in the SCA checks are labeled
When the user navigates to the SCA checks
Then the kpi that displays the checks that passed is labeled as
Passed
And the kpi that displays the checks that failed is labeled as
Failed
And the kpi that displays the checks that are not applicable is labeled as
Not applicable
Scenario 5 The result for the checks displayed in the SCA checks table are labeled
When the user navigates to the SCA checks table
Then the check that passed is labeled as
Passed
And the check that failed is labeled as
Failed
And the check that didn't apply is labeled as
Not applicable
Scenario 6 The result for the checks displayed in the SCA policies table are labeled
When the user navigates to the SCA policies table
Then the checks count that passed are labeled as
Passed
And the checks count that failed are labeled as
Failed
And the checks count that didn't apply are labeled as
Not applicable
Scenario 7 The results for the checks displayed in the SCA policies visualization are labeled
When the user navigates to the SCA policies and sees the visualizations
Then the checks count that passed are labeled as
Passed
And the checks count that failed are labeled as
Failed
And the checks count that didn't apply are labeled as
Not applicable
Scenario 8 The results for the checks displayed in the SCA policies table in the agent overview are labeled
When the user navigates to the agent overview and sees the SCA policies table
Then the checks count that passed are labeled as
Passed
And the checks count that failed are labeled as
Failed
And the checks count that didn't apply are labeled as
Not applicable
Check List
yarn test:jest