Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sensor: tdk 42688 driver #52911

Merged
merged 3 commits into from
Jan 10, 2023
Merged

sensor: tdk 42688 driver #52911

merged 3 commits into from
Jan 10, 2023

Conversation

yperess
Copy link
Collaborator

@yperess yperess commented Dec 8, 2022

Adds a driver for TDK InvenSense 42688 six axis IMU. Verified using the sensor shell sample app via:

sensor info
sensor get icm42688p@0
Collaborated on by Tom Burdick and Yuval Peress

@yperess yperess requested a review from teburd December 8, 2022 17:28
@yperess yperess mentioned this pull request Dec 8, 2022
Closed
@zephyrbot zephyrbot added area: Devicetree Binding PR modifies or adds a Device Tree binding area: Sensors Sensors labels Dec 8, 2022
teburd
teburd previously approved these changes Dec 9, 2022
View reviewed changes
Copy link
Collaborator

@teburd teburd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this, I have some patches I can PR once in.

samples/sensor/sensor_shell/prj.conf Outdated Show resolved Hide resolved
teburd
teburd previously approved these changes Dec 9, 2022
View reviewed changes
MaureenHelm
MaureenHelm requested changes Dec 12, 2022
View reviewed changes
Copy link
Member

@MaureenHelm MaureenHelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the sensor to tests/drivers/build_all/sensor to ensure it gets built in CI

boards/arm/tdk_robokit1/tdk_robokit1_defconfig Outdated Show resolved Hide resolved
drivers/sensor/icm42688/Kconfig Outdated Show resolved Hide resolved
drivers/sensor/icm42688/icm42688.h Outdated Show resolved Hide resolved
dts/bindings/sensor/invensense,icm42688.yaml Outdated Show resolved Hide resolved
dts/bindings/sensor/invensense,icm42688.yaml Outdated Show resolved Hide resolved
dts/bindings/sensor/invensense,icm42688.yaml Outdated Show resolved Hide resolved
dts/bindings/sensor/invensense,icm42688.yaml Outdated Show resolved Hide resolved
dts/bindings/sensor/invensense,icm42688.yaml Outdated Show resolved Hide resolved
samples/sensor/sensor_shell/prj.conf Outdated Show resolved Hide resolved
keith-zephyr
keith-zephyr reviewed Dec 12, 2022
View reviewed changes
drivers/sensor/icm42688/icm42688.c Outdated Show resolved Hide resolved
drivers/sensor/icm42688/icm42688_core.c Outdated Show resolved Hide resolved
@yperess yperess force-pushed the push-bot/v1tdk_driver branch 2 times, most recently from bb2c8c3 to 1822dbe Compare December 13, 2022 04:46
@yperess yperess requested a review from nashif as a code owner December 13, 2022 04:46
@yperess
Copy link
Collaborator Author

yperess commented Dec 13, 2022 •
edited
Loading

Please add the sensor to tests/drivers/build_all/sensor to ensure it gets built in CI

@MaureenHelm I tried this but ran into a few issues (see the second commit in this PR)

  1. The test wasn't passing due to conflicting addresses (I fixed that)
  2. The driver requires the SPI_SAM (@teburd can you confirm?) which can't be built for native_posix, so I can't seem to add it to this test without major refactoring.

@yperess yperess force-pushed the push-bot/v1tdk_driver branch 4 times, most recently from c409918 to 7005493 Compare December 13, 2022 06:54
@yperess
Copy link
Collaborator Author

yperess commented Dec 13, 2022

Please add the sensor to tests/drivers/build_all/sensor to ensure it gets built in CI

@MaureenHelm I tried this but ran into a few issues (see the second commit in this PR)

  1. The test wasn't passing due to conflicting addresses (I fixed that)
  2. The driver requires the SPI_SAM (@teburd can you confirm?) which can't be built for native_posix, so I can't seem to add it to this test without major refactoring.

Discussed with @teburd offline and there's no hard requirement for the SPI_SAM, CI should pass now

keith-zephyr
keith-zephyr previously approved these changes Dec 14, 2022
View reviewed changes
teburd
teburd previously approved these changes Dec 14, 2022
View reviewed changes
keith-zephyr
keith-zephyr previously approved these changes Dec 14, 2022
View reviewed changes
MaureenHelm
MaureenHelm requested changes Jan 4, 2023
View reviewed changes
Copy link
Member

@MaureenHelm MaureenHelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, but otherwise looks good. Also needs a rebase

drivers/sensor/icm42688/icm42688.h Outdated Show resolved Hide resolved
@yperess yperess dismissed stale reviews from keith-zephyr and teburd via 32b6195 January 10, 2023 07:33
@yperess yperess force-pushed the push-bot/v1tdk_driver branch 2 times, most recently from c501ab7 to ab4f363 Compare January 10, 2023 07:46
teburd and others added 3 commits January 10, 2023 11:37
@teburd @yperess
sensor: tdk 42688 driver
547f461 
Adds a driver for TDK InvenSense 42688 six axis IMU. Verified using
the sensor shell sample app via:

- sensor info
- sensor get icm42688p@0

Signed-off-by: Tom Burdick <[email protected]>
Signed-off-by: Yuval Peress <[email protected]>
@yperess
tests: clean up build_all/sensor
c6425f2 
The test at tests/drivers/build_all/sensor wasn't passing since a lot
of nodes in both the i2c and spi had conflicting addresses. Fix that by
making the addresses sequential.

Signed-off-by: Yuval Peress <[email protected]>
@yperess
test: add icm42688 to build_all/sensor test
8ca6650 
Add a node for the icm42688 so that it builds as a part of the CI.

Signed-off-by: Yuval Peress <[email protected]>
@MaureenHelm MaureenHelm merged commit aea1770 into zephyrproject-rtos:main Jan 10, 2023
@teburd teburd mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teburd teburd teburd approved these changes

@MaureenHelm MaureenHelm MaureenHelm approved these changes

@galak galak Awaiting requested review from galak

@avisconti avisconti Awaiting requested review from avisconti

@nashif nashif Awaiting requested review from nashif

@keith-zephyr keith-zephyr Awaiting requested review from keith-zephyr

Assignees

@MaureenHelm MaureenHelm

Labels
area: Devicetree Binding PR modifies or adds a Device Tree binding area: Sensors Sensors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yperess @teburd @MaureenHelm @keith-zephyr @zephyrbot