Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin unhandled exception #3349

Merged
merged 6 commits into from
Jun 21, 2024
Merged

Plugin unhandled exception #3349

merged 6 commits into from
Jun 21, 2024

Conversation

Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Jun 19, 2024 •
edited
Loading

Description

This merge the branch into master.

Fixes # (issue)

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Jim8y and others added 2 commits June 16, 2024 19:24
@Jim8y @cschuchardt88
[Neo Core] Part 1. Isolate Plugins Exceptions from the Node. (#3309)
89d6ea3 
* catch plugin exceptions.

* add UT test

* udpate format

* make the test  more complete

* complete the ut test

* format

* complete UT tests with NonPlugin case

* async invoke

* Update src/Neo/Ledger/Blockchain.cs

Co-authored-by: Christopher Schuchardt <[email protected]>

---------

Co-authored-by: Christopher Schuchardt <[email protected]>
@Jim8y @shargon @cschuchardt88
[Neo Plugin New feature] UnhandledExceptionPolicy on Plugin Unhandled…
c696cec 
… Exception (#3311)

* catch plugin exceptions.

* add UT test

* udpate format

* make the test  more complete

* complete the ut test

* format

* complete UT tests with NonPlugin case

* async invoke

* stop plugin on exception

* remove watcher from blockchain if uint test is done to avoid cross test data pollution.

* add missing file

* 3 different policy on handling plugin exception

* add missing file

* fix null warning

* format

* Apply suggestions from code review

Clean

* Update src/Neo/Plugins/PluginSettings.cs

Co-authored-by: Shargon <[email protected]>

* Update src/Neo/Plugins/PluginSettings.cs

Co-authored-by: Christopher Schuchardt <[email protected]>

* Update src/Plugins/TokensTracker/TokensTracker.cs

Co-authored-by: Christopher Schuchardt <[email protected]>

* Update src/Plugins/TokensTracker/TokensTracker.json

---------

Co-authored-by: Shargon <[email protected]>
Co-authored-by: Christopher Schuchardt <[email protected]>
@NGDAdmin NGDAdmin merged commit b2f060f into master Jun 21, 2024
7 checks passed
@NGDAdmin NGDAdmin deleted the plugin-unhandled-exception branch June 21, 2024 09:18
vncoelho added a commit that referenced this pull request Jun 28, 2024
@vncoelho
Revert "Plugin unhandled exception (#3349)"
28719fb 
This reverts commit b2f060f.
@vang1ong7ang vang1ong7ang mentioned this pull request Jul 17, 2024
Merged
NGDAdmin pushed a commit that referenced this pull request Jul 17, 2024
@vncoelho @cschuchardt88
Revert "Plugin unhandled exception (#3349)" (#3366)
f307a31 
This reverts commit b2f060f.

Co-authored-by: Christopher Schuchardt <[email protected]>
@vncoelho vncoelho mentioned this pull request Jul 18, 2024
Closed
Jim8y added a commit to Jim8y/neo that referenced this pull request Jul 18, 2024
@Jim8y
Revert "Revert "Plugin unhandled exception (neo-project#3349)" (neo-p…
a7f39ef 
…roject#3366)"

This reverts commit f307a31.
Jim8y added a commit to Jim8y/neo that referenced this pull request Jul 18, 2024
@Jim8y
Merge branch 'master' into fix-compound-reference
a28ec0b 
* master: (27 commits)
  Revert "Plugin unhandled exception (neo-project#3349)" (neo-project#3366)
  `[Move]` Part-2 Classes into Different Library - `Neo.IO` (neo-project#3388)
  [Neo Core Store] Rename various snapshots. (neo-project#3406)
  [Neo Core Storage] Implicit methods and tests (neo-project#3403)
  [Neo Core MemoryStore] MemoryStore Unit Tests. (neo-project#3404)
  Fixed Publish Step (neo-project#3411)
  Fix release compilation (neo-project#3417)
  [Neo Plugin UT] Rpcserver unit test on node (neo-project#3353)
  Improve code coverage (neo-project#3354)
  `[Add]` Debug Output to `Expect` (neo-project#3407)
  [Neo Plugin Store] Unit test (neo-project#3399)
  Bump System.Text.Json from 8.0.3 to 8.0.4 in /src/Neo.Json (neo-project#3416)
  `[Typo]` Unit Tests - UT_ProtocolSettings.CreateHKSettings (neo-project#3383)
  `[Fix]` Test Problems (neo-project#3398)
  Part-1 `Neo.IO` - move (neo-project#3387)
  Fixed Props Pathing for `dotnet pack` with `nuget` (neo-project#3379)
  `[neo-cli]` Error Message and Warning - LevelDb (neo-project#3380)
  Fix crash when comparing ContractPermissionDescriptor (neo-project#3396)
  `DeprecatedIn` for events (neo-project#3362)
  Fix download tips (neo-project#3395)
  ...
Jim8y added a commit to Jim8y/neo that referenced this pull request Jul 18, 2024
@Jim8y
Revert "Revert "Plugin unhandled exception (neo-project#3349)" (neo-p…
a4cade1 
…roject#3366)"

This reverts commit f307a31.
Jim8y added a commit to Jim8y/neo that referenced this pull request Jul 18, 2024
@Jim8y
Merge branch 'fix-plugin-exception' of github.com:Jim8y/neo into fix-…
da31567 
…plugin-exception

* 'fix-plugin-exception' of github.com:Jim8y/neo:
  Update src/Neo/Plugins/UnhandledExceptionPolicy.cs
  ensure leveldb is not used in multithread env
  Revert "Revert "Plugin unhandled exception (neo-project#3349)" (neo-project#3366)"

# Conflicts:
#	src/Neo/Ledger/Blockchain.cs
#	src/Neo/Plugins/UnhandledExceptionPolicy.cs
#	tests/Neo.UnitTests/Plugins/TestPlugin.cs
#	tests/Neo.UnitTests/Plugins/UT_Plugin.cs
NGDAdmin added a commit that referenced this pull request Aug 6, 2024
@Jim8y @cschuchardt88
@shargon @NGDAdmin
Fix plugin exception (#3426)
1488958 
* Revert "Revert "Plugin unhandled exception (#3349)" (#3366)"

This reverts commit f307a31.

* ensure leveldb is not used in multithread env

* Revert "Revert "Plugin unhandled exception (#3349)" (#3366)"

This reverts commit f307a31.

* remove async.

* Update src/Neo/Plugins/UnhandledExceptionPolicy.cs

Co-authored-by: Christopher Schuchardt <[email protected]>

* not use linq

* Update src/Neo/Plugins/UnhandledExceptionPolicy.cs

Co-authored-by: Christopher Schuchardt <[email protected]>

* use ignore case

* Update src/Plugins/TokensTracker/TokensTracker.cs

* Update src/Neo/Plugins/Plugin.cs

Co-authored-by: Shargon <[email protected]>

---------

Co-authored-by: Christopher Schuchardt <[email protected]>
Co-authored-by: Shargon <[email protected]>
Co-authored-by: NGD Admin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

@cschuchardt88 cschuchardt88 cschuchardt88 approved these changes

@vncoelho vncoelho Awaiting requested review from vncoelho

@roman-khimov roman-khimov Awaiting requested review from roman-khimov

@AnnaShaleva AnnaShaleva Awaiting requested review from AnnaShaleva

Assignees
No one assigned
Labels
ready to merge waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jim8y @shargon @cschuchardt88 @NGDAdmin