Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes] Props Duplicate - Path Packing #3379

Merged
merged 5 commits into from
Jul 5, 2024

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Jul 1, 2024

Description

Fixed Props Pathing for dotnet pack with nuget

Change Log

  • Remove duplicate Paths in ./src/Plugins/Directory.Build.props
  • Removes warning for files already added on dotnet pack

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Locally

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's happens if you want to pack only plugins?

@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Jul 1, 2024

@shargon
Doing the from solution you get (PR fixes this)
image

Doing it just from *.csproj of plugins (this won't happen rare case)
image

@NGDAdmin NGDAdmin merged commit 8e1e661 into neo-project:master Jul 5, 2024
7 checks passed
@shargon shargon deleted the fix/props-nuget-path branch July 5, 2024 06:54
Jim8y added a commit to Jim8y/neo that referenced this pull request Jul 18, 2024
* master: (27 commits)
  Revert "Plugin unhandled exception (neo-project#3349)" (neo-project#3366)
  `[Move]` Part-2 Classes into Different Library - `Neo.IO` (neo-project#3388)
  [Neo Core Store] Rename various snapshots. (neo-project#3406)
  [Neo Core Storage] Implicit methods and tests (neo-project#3403)
  [Neo Core MemoryStore] MemoryStore Unit Tests. (neo-project#3404)
  Fixed Publish Step (neo-project#3411)
  Fix release compilation (neo-project#3417)
  [Neo Plugin UT] Rpcserver unit test on node (neo-project#3353)
  Improve code coverage (neo-project#3354)
  `[Add]` Debug Output to `Expect` (neo-project#3407)
  [Neo Plugin Store] Unit test (neo-project#3399)
  Bump System.Text.Json from 8.0.3 to 8.0.4 in /src/Neo.Json (neo-project#3416)
  `[Typo]` Unit Tests - UT_ProtocolSettings.CreateHKSettings (neo-project#3383)
  `[Fix]` Test Problems (neo-project#3398)
  Part-1 `Neo.IO` - move (neo-project#3387)
  Fixed Props Pathing for `dotnet pack` with `nuget` (neo-project#3379)
  `[neo-cli]` Error Message and Warning - LevelDb (neo-project#3380)
  Fix crash when comparing ContractPermissionDescriptor (neo-project#3396)
  `DeprecatedIn` for events (neo-project#3362)
  Fix download tips (neo-project#3395)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants