Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Move] Part-2 Classes into Different Library - Neo.IO #3388

Merged
merged 12 commits into from
Jul 16, 2024
Merged

[Move] Part-2 Classes into Different Library - Neo.IO #3388

merged 12 commits into from
Jul 16, 2024

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Jul 2, 2024 •
edited
Loading

Description

Reorganized and move classes from neo library to neo.io library.

Fixed problems and warnings that occurred. Along with naming violations.

Change Log

  • Move ReflectionCacheAttribute.cs to ./src/Neo.IO/Caching folder
  • Move Idle.cs to ./src/Neo.IO/Actors folder
  • Optimization of Neo.IO.Actors & Neo.IO.Caching namespace in neo library
  • Added BigInteger extensions to Neo.Extensions

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit Testing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cschuchardt88 cschuchardt88 added blocked This issue can't be worked at the moment waiting for review labels Jul 2, 2024
@cschuchardt88 cschuchardt88 requested a review from a team July 2, 2024 09:29
@cschuchardt88 cschuchardt88 removed the blocked This issue can't be worked at the moment label Jul 5, 2024
@shargon
Copy link
Member

shargon commented Jul 5, 2024

could you add more changes to this part, it's only 2 moves, the rest is styling (not related)

@cschuchardt88
Copy link
Member Author

Neo.IO Is all done, that's the last of it. Because didn't want to make Part-1 to big.

@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Jul 5, 2024 •
edited
Loading

@shargon Added BigInteger extensions to Neo.Extensions

@cschuchardt88 cschuchardt88 added the blocker Issues that are blocking other issues. Check issues details to see what it is blocking. label Jul 5, 2024
Jim8y
Jim8y previously approved these changes Jul 6, 2024
View reviewed changes
@cschuchardt88 cschuchardt88 added blocker Issues that are blocking other issues. Check issues details to see what it is blocking. and removed blocker Issues that are blocking other issues. Check issues details to see what it is blocking. labels Jul 7, 2024
@cschuchardt88 cschuchardt88 requested a review from Jim8y July 9, 2024 18:15
@cschuchardt88
Copy link
Member Author

@shargon
Moved tests to Neo.Extensions.Tests

@Jim8y Jim8y requested a review from shargon July 15, 2024 15:28
@Jim8y Jim8y added ready to merge and removed blocker Issues that are blocking other issues. Check issues details to see what it is blocking. waiting for review labels Jul 16, 2024
@shargon shargon merged commit 03fc303 into neo-project:master Jul 16, 2024
6 of 7 checks passed
@shargon shargon deleted the rebuild/the-split-2 branch July 16, 2024 16:05
Jim8y added a commit to Jim8y/neo that referenced this pull request Jul 18, 2024
@Jim8y
Merge branch 'master' into fix-compound-reference
a28ec0b 
* master: (27 commits)
  Revert "Plugin unhandled exception (neo-project#3349)" (neo-project#3366)
  `[Move]` Part-2 Classes into Different Library - `Neo.IO` (neo-project#3388)
  [Neo Core Store] Rename various snapshots. (neo-project#3406)
  [Neo Core Storage] Implicit methods and tests (neo-project#3403)
  [Neo Core MemoryStore] MemoryStore Unit Tests. (neo-project#3404)
  Fixed Publish Step (neo-project#3411)
  Fix release compilation (neo-project#3417)
  [Neo Plugin UT] Rpcserver unit test on node (neo-project#3353)
  Improve code coverage (neo-project#3354)
  `[Add]` Debug Output to `Expect` (neo-project#3407)
  [Neo Plugin Store] Unit test (neo-project#3399)
  Bump System.Text.Json from 8.0.3 to 8.0.4 in /src/Neo.Json (neo-project#3416)
  `[Typo]` Unit Tests - UT_ProtocolSettings.CreateHKSettings (neo-project#3383)
  `[Fix]` Test Problems (neo-project#3398)
  Part-1 `Neo.IO` - move (neo-project#3387)
  Fixed Props Pathing for `dotnet pack` with `nuget` (neo-project#3379)
  `[neo-cli]` Error Message and Warning - LevelDb (neo-project#3380)
  Fix crash when comparing ContractPermissionDescriptor (neo-project#3396)
  `DeprecatedIn` for events (neo-project#3362)
  Fix download tips (neo-project#3395)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

@Jim8y Jim8y Jim8y approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cschuchardt88 @shargon @Jim8y