[Neo Core Store] Rename various snapshots.

[Jim8y]

Description

The name of snapshot has being misused almost everywhere in the core, snapshotcache is different from snapshot, and clonedcache is also not a snapshot. Misuse the terminology of snapshot confuses developers.

Fixes # (issue)

Type of change

• Optimization (the change is only an optimization)
• Style (the change is only a code style for better maintenance or standard purpose)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Test Configuration:

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[shargon]

all are changed?

[Jim8y]

all are changed?

what you mean?

[shargon]

all are changed?

what you mean?

if we don't call to the obsolete methods

[Jim8y]

all are changed?

what you mean?

if we don't call to the obsolete methods

Sorry I still dont get that,,, what you mean if we dont call to the absolete methods？

[vncoelho]

Do we need to leave the obsolete methods in the code?

[Jim8y]

Do we need to leave the obsolete methods in the code?

Yes, cause people could be using them since they are public, we can not remove them until the verion after the next version.

[Jim8y]

@shargon