[Neo Core Storage] Implicit methods and tests #3403
Conversation
| @@ -193,5 +193,15 @@ public void Set(IInteroperable interoperable) | |||
| item.cache ??= new BigInteger(item.value.Span); | |||
| return (BigInteger)item.cache; | |||
| } | |||
|
|
|||
| public static implicit operator StorageItem(BigInteger value) | |||
There was a problem hiding this comment.
I'm just wondering, do you have a use-case for these conversion operators in the code? Usually when we introduce such helpers, there's a need to use them in the code and we replace some real code with these helpers.
There was a problem hiding this comment.
Doesn't matter how it done. As long as the do the same thing. We have direct access to the class. So, no need for extension methods. Plus this doesn't convert to BigInteger its allows us to compare the two.
There was a problem hiding this comment.
I'm just wondering, do you have a use-case for these conversion operators in the code? Usually when we introduce such helpers, there's a need to use them in the code and we replace some real code with these helpers.
Does it matter ?
* master: (27 commits) Revert "Plugin unhandled exception (neo-project#3349)" (neo-project#3366) `[Move]` Part-2 Classes into Different Library - `Neo.IO` (neo-project#3388) [Neo Core Store] Rename various snapshots. (neo-project#3406) [Neo Core Storage] Implicit methods and tests (neo-project#3403) [Neo Core MemoryStore] MemoryStore Unit Tests. (neo-project#3404) Fixed Publish Step (neo-project#3411) Fix release compilation (neo-project#3417) [Neo Plugin UT] Rpcserver unit test on node (neo-project#3353) Improve code coverage (neo-project#3354) `[Add]` Debug Output to `Expect` (neo-project#3407) [Neo Plugin Store] Unit test (neo-project#3399) Bump System.Text.Json from 8.0.3 to 8.0.4 in /src/Neo.Json (neo-project#3416) `[Typo]` Unit Tests - UT_ProtocolSettings.CreateHKSettings (neo-project#3383) `[Fix]` Test Problems (neo-project#3398) Part-1 `Neo.IO` - move (neo-project#3387) Fixed Props Pathing for `dotnet pack` with `nuget` (neo-project#3379) `[neo-cli]` Error Message and Warning - LevelDb (neo-project#3380) Fix crash when comparing ContractPermissionDescriptor (neo-project#3396) `DeprecatedIn` for events (neo-project#3362) Fix download tips (neo-project#3395) ...
Description
This pr adds implicit methods for StorageItem and StorageKey, and also added Unit Test to test them.
Fixes # (issue)
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: