-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Neo Plugin UT] Rpcserver unit test on node #3353
Conversation
* master: Fixed pathing and Property (neo-project#3306) [Neo CLI New Feature] Allow custom plugins (neo-project#3295) Return expect to verify neo-cli (neo-project#3318) [Neo CLI Optimization] fix exception message (neo-project#3314) fix plugin download url (neo-project#3329)
Coverage is not working and some verification are failing, Jimmy. |
i.know, i will fix that, i changed testing utils and that caused some test fail |
Sure, as soon as fixed I will review here again. I just verified something related to Debug for the method clear of mempool. |
Have to update some existing tests cause i updated the timestamp of the test block since it was the same as genesis block. |
#if DEBUG | ||
// This method is only for test purpose | ||
// Do not remove it from the DEBUG build | ||
internal void Clear() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it doesn't hurt without debug, it's already internal, but it's ok for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we compile in release maybe it fault because the UT require this method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then add to test the same way as #if DEBUG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jim8y we need to compile the whole sln in release, I think it won't work with this change
* master: Fixed Publish Step (neo-project#3411) Fix release compilation (neo-project#3417) [Neo Plugin UT] Rpcserver unit test on node (neo-project#3353) Improve code coverage (neo-project#3354) `[Add]` Debug Output to `Expect` (neo-project#3407) [Neo Plugin Store] Unit test (neo-project#3399) Bump System.Text.Json from 8.0.3 to 8.0.4 in /src/Neo.Json (neo-project#3416) # Conflicts: # tests/Neo.Plugins.RpcServer.Tests/TestBlockchain.cs # tests/Neo.UnitTests/Network/P2P/Payloads/UT_Header.cs
* master: (27 commits) Revert "Plugin unhandled exception (neo-project#3349)" (neo-project#3366) `[Move]` Part-2 Classes into Different Library - `Neo.IO` (neo-project#3388) [Neo Core Store] Rename various snapshots. (neo-project#3406) [Neo Core Storage] Implicit methods and tests (neo-project#3403) [Neo Core MemoryStore] MemoryStore Unit Tests. (neo-project#3404) Fixed Publish Step (neo-project#3411) Fix release compilation (neo-project#3417) [Neo Plugin UT] Rpcserver unit test on node (neo-project#3353) Improve code coverage (neo-project#3354) `[Add]` Debug Output to `Expect` (neo-project#3407) [Neo Plugin Store] Unit test (neo-project#3399) Bump System.Text.Json from 8.0.3 to 8.0.4 in /src/Neo.Json (neo-project#3416) `[Typo]` Unit Tests - UT_ProtocolSettings.CreateHKSettings (neo-project#3383) `[Fix]` Test Problems (neo-project#3398) Part-1 `Neo.IO` - move (neo-project#3387) Fixed Props Pathing for `dotnet pack` with `nuget` (neo-project#3379) `[neo-cli]` Error Message and Warning - LevelDb (neo-project#3380) Fix crash when comparing ContractPermissionDescriptor (neo-project#3396) `DeprecatedIn` for events (neo-project#3362) Fix download tips (neo-project#3395) ...
Description
This is the second pr that focus on adding unit tests for rpcservers.
Fixes # #3350
Type of change
How Has This Been Tested?
Here is the list of method names extracted from the provided code:
Test Configuration:
Checklist: